Repository navigation
fix: use X-Forwarded-Uri if it exists for pathRegex match - #4
Closed
deb-hacktron wants to merge 1 commit into
Closed
deb-hacktron wants to merge 1 commit into
deb-hacktron wants to merge 1 commit into
Conversation
| func (p *OAuthProxy) isAllowedRoute(req *http.Request) bool { | ||
| for _, route := range p.allowedRoutes { | ||
| if (route.method == "" || req.Method == route.method) && route.pathRegex.MatchString(req.URL.Path) { | ||
| if (route.method == "" || req.Method == route.method) && route.pathRegex.MatchString(util.GetRequestURI(req)) { |
There was a problem hiding this comment.
🔴 High: Authentication Bypass via Unanchored Regex in Allowed Routes
The isAllowedRoute function uses unanchored regular expressions to validate request paths against the SkipAuthRoutes allowlist. Because these regular expressions are not anchored to the start of the URI (e.g., using ^), a route configured as /public will match any URI containing the string /public, such as /admin/public or /api/v1/public/../../secret. This allows attackers to bypass authentication for sensitive routes by crafting requests that contain the allowed path string.
Steps to Reproduce
- Configure OAuth2 Proxy with
skip-auth-routes = ["/public"]. - Observe that requests to
/publicare allowed without authentication. - Send a request to
/admin/public. - Observe that the request to
/admin/publicis also allowed without authentication because the regex/publicmatches anywhere in the URI.
Trace
graph TD
subgraph SG0 ["./oauth2-proxy/oauthproxy.go"]
IsAllowedRequest["IsAllowedRequest"]
isAllowedRoute{{"Evaluates whether a request's method and path match the configured allowlist, permitting access without authentication."}}
serveHTTP["serveHTTP"]
end
style SG0 fill:#2a2a2a,stroke:#444,color:#aaa
IsAllowedRequest --> isAllowedRoute
serveHTTP --> IsAllowedRequest
Fix with AI
Fix the following security vulnerability found by Hacktron.
File: oauthproxy.go
Lines: 703
Severity: high
Vulnerability: Authentication Bypass via Unanchored Regex in Allowed Routes
Description:
The `isAllowedRoute` function uses unanchored regular expressions to validate request paths against the `SkipAuthRoutes` allowlist. Because these regular expressions are not anchored to the start of the URI (e.g., using `^`), a route configured as `/public` will match any URI containing the string `/public`, such as `/admin/public` or `/api/v1/public/../../secret`. This allows attackers to bypass authentication for sensitive routes by crafting requests that contain the allowed path string.
Proof of Concept:
**Steps to Reproduce**
1. Configure OAuth2 Proxy with `skip-auth-routes = ["/public"]`.
2. Observe that requests to `/public` are allowed without authentication.
3. Send a request to `/admin/public`.
4. Observe that the request to `/admin/public` is also allowed without authentication because the regex `/public` matches anywhere in the URI.
Affected Code:
func (p *OAuthProxy) isAllowedRoute(req *http.Request) bool {
for _, route := range p.allowedRoutes {
if (route.method == "" || req.Method == route.method) && route.pathRegex.MatchString(util.GetRequestURI(req)) {
return true
}
}
return false
}
Fix this vulnerability. Only change what's necessary - don't modify unrelated code.
Triage: Reply !fp (false positive), !valid (confirmed), or !accepted_risk. Any other reply is saved as a triage note.
Owner
Author
|
Refreshing scan with a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minimal historical bug recreation for internal review-bot demo with dummy-authored commits.