Skip to content

fix: harden validation evidence and release readiness - #61

Merged
vriesd merged 1 commit into
mainfrom
craft/evidence-hardening-8.2.1
Sep 5, 2026
Merged

fix: harden validation evidence and release readiness#61
vriesd merged 1 commit into
mainfrom
craft/evidence-hardening-8.2.1

Conversation

@vriesd

@vriesd vriesd commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Review Findings Addressed

  • CRAFT-01: replace regex JUnit extraction with strict XML parsing; reject malformed/truncated documents and DTDs, exclude comment/CDATA/log cases, preserve valid labels and negative outcomes.
  • CRAFT-02: distinguish Git index records from literal untracked filenames and reject lossy UTF-8 decoding. Real Git regressions cover H/S/M/? records and staging-independent effective content.
  • CRAFT-03: require exact assets before an already-published release reports prepared; keep preparation read-only and explicit publish recovery available.
  • CRAFT-04: prepare 8.2.1 metadata, correct lock-recovery documentation and Biome schema drift, and update the SDK transitive toml lock to patched 4.3.0.
  • Independent review follow-up: remove quadratic JUnit ancestry scans with constant-time bookkeeping and a near-cap deep-report regression.

Simplicity And Compatibility

No new lifecycle state, public tools, commands, schemas, runner adapters, or raised budgets. Session v5 is unchanged. XML parsing belongs to infrastructure, with saxes replacing a custom grammar. Runtime TypeScript is smaller; the strict parser adds roughly 60 KB to the bundle.

Validation

  • bun run check: 717 passed, 1 opt-in skip, 0 failed
  • bun run replay: 13/13 reproduced
  • bun run smoke:live: 14 passed
  • bun audit --audit-level=high: no vulnerabilities
  • Frozen lockfile installation and commit/push contribution preflights passed
  • Independent Flow reviews passed every phase and the performance follow-up; the requested S/M coverage gap was fixed in a fresh reviewed run
  • Optional gitleaks executable unavailable; staged and outgoing changes manually inspected

Delivery Boundary

This PR is a locally reviewed patch candidate, not a release qualification claim. Merge requires green remote checks and resolved blocking review. Tagging/publication must wait for successful main CI, a fresh exact-artifact canary, and a sealed two-provider qualification campaign. No release safeguard is bypassed.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 5, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-05T00:51:40.639788Z 0e3ebc5 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@vriesd
vriesd merged commit 79814f3 into main Sep 5, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants