refactor(status): remove the redundant health mirror - #140
Open
vriesd wants to merge 1 commit into
Open
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Health was stored in both
HealthCacheState.cachedand aHEALTHmirror. This implements Plan 22's first unit by keeping the existing cache as the sole authoritative cached value.Scope
Remove the mirror, its initialization copy, publication callback, invalidation writes, and test re-export. GNOME fixtures now seed the actual cache after advancing its generation. The one-second source check, ten-second TTL, background refresh, and invalidation callers retain their behavior.
Verification
All 20 status tests and seven non-ignored GNOME tests passed. The new cache test verifies repeated fixture seeding and rejects pending work from an older generation. Independent source review found no blockers. The two environment-dependent GNOME cases remain ignored; physical desktop acceptance is still open.