Repository navigation
fix(scripts): find the running api container through compose - #189
Merged
Merged
Conversation
download.sh and export_paddleocr.sh matched the bare name 'api' against
docker ps, but the container is named ${COMPOSE_PROJECT_NAME}-api, so the
check never hit and the temporary-container branch always ran. Resolve the
service with 'dc ps -q' (explicit -p project) instead. export_paddleocr.sh
gains a project-scoped dc() and uses it for every compose call.
Closes #187
davidamacey
changed the base branch from
refactor/rename-api-service-62
to
main
October 9, 2026 14:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #187
download.sh and export_paddleocr.sh matched the bare name
api(andtriton-server) againstdocker ps, but containers are named${COMPOSE_PROJECT_NAME}-<service>, so the check never hit and the temporary-container branch always ran. Both now resolve the service through compose with an explicit project (dc ps -q <service>). export_paddleocr.sh gets a project-scopeddc()used for all its compose calls.Tests: tests/installer/test_api_container_check.py (docker shim; shim gained a generic
<service>_containerfixture). 3 of 4 tests fail on the old code, all pass now.Based on #186 (refactor/rename-api-service-62). Retarget to main if #186 merges first.