Repository navigation
refactor(config): remove the unread ocr_det_* region profile fields - #182
Merged
Merged
Conversation
…TER_INDEX, assign_cluster_to_crop Closes #174
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #181
Stacked on #180 (branch cleanup/dead-symbols-174, which deletes PaddleOcrRegionDetector); that PR's commit shows in this diff until it merges. Merge #180 first.
Changes
ocr_det_model,ocr_det_version,ocr_det_input_size,ocr_det_prob_floorfromDetectionProfile,RegionProfileBody, the license_plate example, docs, tests and contracts (regenerated).ocr_det_modelTriton readiness check, the unload guard and promoted-models listing entries, the 'OCR text hint' detector vocabulary entry, and theocr_det_modelschoices_fromvalue. Theocr.det_modelsvocabulary list stays.ocr_engine_id(stamped asregion_text_engine_version) is now<rec model>:<version>.profile_field_unknown) with a message naming the key and saying it is retired (RETIRED_PROFILE_FIELDSinprofile_registry.py). Tests cover the validate path and the stored-doc load path.OCR_DET_MODEL(settings.py / ocr_service.py) is untouched.Verification
npm run check0 errors,npm test4390 passed.pre-commit run --from-ref origin/main --to-ref HEADexit 0.