refactor: build manifest statistics fixtures in memory - #706
Closed
alexanderbianchi wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original proposal
Draft example of #700's generic
with_file(uri, bytes)support. Adds two integration tests using manifests and a manifest list serialized by Iceberg's native writers into memory, without new harness methods or dependencies.The fixture contains two data files with known metrics for vendor_id (Iceberg field ID 1) and passenger_count (ID 4). Tests assert:
Unlike the checked-in taxi manifest, whose column metric maps are empty, this fixture produces populated column statistics. The tests use synthetic data-file paths and only plan queries; they do not claim to validate statistics against actual Parquet contents. File row counts and sizes sum to the existing snapshot summary totals.
Stacked on #700 (
codex/iceberg-runtime-metadata). Missing-metric combinations, multiple manifests, delete files, and NDV metadata were outside this initial example.Original validation
Absentvalues; the mutation was reverted.cargo test -p datafusion-distributed-iceberg --locked— 92 tests passed, including the doctestcargo clippy -p datafusion-distributed-iceberg --tests --locked -- -D warningscargo fmt --all -- --checkgit diff --check