refactor: construct historical Iceberg fixtures in tests - #702
Open
alexanderbianchi wants to merge 1 commit into
Open
refactor: construct historical Iceberg fixtures in tests#702alexanderbianchi wants to merge 1 commit into
alexanderbianchi wants to merge 1 commit into
Conversation
This was referenced Sep 5, 2026
Closed
alexanderbianchi
force-pushed
the
codex/iceberg-time-travel-regression
branch
from
September 5, 2026 20:52
8119b08 to
ec92d04
Compare
alexanderbianchi
changed the title
alexanderbianchi
force-pushed
the
codex/iceberg-runtime-metadata
branch
from
September 5, 2026 21:22
71a906b to
3445b6a
Compare
alexanderbianchi
force-pushed
the
codex/iceberg-time-travel-regression
branch
2 times, most recently
from
September 5, 2026 22:57
93f3c00 to
99c8032
Compare
alexanderbianchi
force-pushed
the
codex/iceberg-time-travel-regression
branch
from
September 6, 2026 00:18
99c8032 to
6c531ec
Compare
alexanderbianchi
force-pushed
the
codex/iceberg-runtime-metadata
branch
from
September 6, 2026 00:18
158065b to
cdf47f7
Compare
alexanderbianchi
marked this pull request as ready for review
September 7, 2026 14:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #700, rebased onto
iceberg-0.10at6507bf8after #687 merged.Strengthens #687's existing selected-snapshot test rather than adding a duplicate. A test-local helper uses native Iceberg builders to add snapshot 42 while leaving the original taxi snapshot current. The completed metadata and
iceberg.snapshot_id = 42are supplied through #700's generic harness inputs.The test now passes with
Exact(42)rows andExact(4242)bytes, distinguishing the selected snapshot from the current snapshot's 175000 rows. The obsolete TODO has been removed; no production statistics changes are included.The summary totals are deliberately synthetic. The manifest still describes the original taxi data, so this fixture tests statistics planning rather than executing a 42-row scan. This limitation is documented beside its construction.
Validation:
cargo test -p datafusion-distributed-iceberg --locked— 90 tests passed, including all 15 statistics tests and the doctestcargo fmt --all -- --checkgit diff --check