Skip to content

fix: CWE problem in recommend_questions #1306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ulleo merged 1 commit into from
Aug 3, 2026
Merged

fix: CWE problem in recommend_questions #1306

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions backend/apps/chat/api/chat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,14 @@ def _return_empty():
if not record:
return StreamingResponse(_return_empty(), media_type="text/event-stream")

chat = session.get(Chat, record.chat_id)
if not chat:
return StreamingResponse(_return_empty(), media_type="text/event-stream")
if chat.oid != current_user.oid:
raise Exception(f"Chat Record with id {chat_record_id} does not belong to current workspace")
if chat.create_by != current_user.id:
raise Exception(f"Chat Record with id {chat_record_id} not Owned by the current user")

request_question = ChatQuestion(chat_id=record.chat_id, question=record.question if record.question else '')

llm_service = await LLMService.create(session, current_user, request_question, current_assistant, True)
Expand Down Expand Up @@ -404,6 +412,14 @@ async def analysis_or_predict(session: SessionDep, current_user: CurrentUser, ch
if not record:
raise Exception(f"Chat record with id {chat_record_id} not found")

chat = session.get(Chat, record.chat_id)
if not chat:
raise Exception(f"Chat with id {chat.id} not found")
if chat.oid != current_user.oid:
raise Exception(f"Chat Record with id {chat_record_id} does not belong to current workspace")
if chat.create_by != current_user.id:
raise Exception(f"Chat Record with id {chat_record_id} not Owned by the current user")

if not record.chart:
raise Exception(
f"Chat record with id {chat_record_id} has not generated chart, do not support to analyze it")
Expand Down
Loading