adding download script, goldens and validation_config, updated mapping for latest data - #2136
Open
smarthg-gi wants to merge 3 commits into
Open
adding download script, goldens and validation_config, updated mapping for latest data#2136smarthg-gi wants to merge 3 commits into
smarthg-gi wants to merge 3 commits into
Conversation
…g for latest data
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a dynamic data downloader and preprocessor (download.py) for the NCES employed college graduates dataset, replacing a hardcoded URL in manifest.json. It also adds golden data files and a validation configuration to verify the imported data, and simplifies the TMCF mapping. The reviewer recommended increasing the retry attempts to 10 when resolving the URL and downloading the file to ensure robust downloads from the external government website.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.