Repository navigation
fix(history): plan projection tolerates malformed evidence, attempts and items (#469) - #474
Merged
Merged
Conversation
…s cannot fail it (#469)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #469
Summary
evidencepath from plan_projection raises AttributeError on a non-object evidence item and loses a finished stage's report #469:normalize_attemptsstores the reported attempts verbatim inattempts_normalized, andplan_projectionblankedattemptsbut notattempts_normalized, socleanreached anevidencestring and called.items()on its characters.plan_projectionno longer persistsattempts_normalized(it carried raw prose and output), ignores non-objectevidenceentries, and projects a non-listitemsas empty.docs/execution-plan.md.docs/ROADMAP_V2.mdalready lists plan_projection raises AttributeError on a non-object evidence item and loses a finished stage's report #469 in M1.Tests
test_projection_drops_raw_normalized_attemptsandtest_projection_ignores_prose_evidence_entries(string, mixed and non-listevidence; non-listitems); both fail without the fix.tests/test_verification_decisions.pyandtests/test_cycle_history.pypass locally.Supersedes #473, which could not be updated in place after a rebase.