Skip to content

fix(cli): resolve transitive registryDependencies and surface optional resource env vars - #516

Draft
MarioCadenas wants to merge 1 commit into
feat/registry-clifrom
feat/registry-resource-bugfixes
Draft

fix(cli): resolve transitive registryDependencies and surface optional resource env vars#516
MarioCadenas wants to merge 1 commit into
feat/registry-clifrom
feat/registry-resource-bugfixes

Conversation

@MarioCadenas

Copy link
Copy Markdown
Collaborator

Stack 1/7 — base: `feat/registry-cli`

First of a 7-PR stack making `appkit add` resource-aware. Review/merge bottom-up.

What

Fixes three bugs in the registry add flow:

Removed the obsolete UI-branch warn-and-skip.

Tests

9 new tests (the `registry/` dir had none): order, transitive resolution, dedup, cycles, namespace stripping, optional-resource env collection.

Stack

  1. this — resource bugfixes
  2. registry info + requirements listing
  3. .env reconciliation
  4. deploy-config generator + golden fixtures
  5. wire full parity (app.yaml + databricks.yml)
  6. workspace picker (flat)
  7. workspace picker (parent-context)

…l resource env vars

- Plugins declaring registryDependencies now pull their full dependency
  graph on 'appkit add' (previously ignored on the plugin branch and never
  resolved transitively).
- declaredEnvVars walks optional resources too, not just required.
- Add regression tests for the registry add resolver (dir had none).

Signed-off-by: MarioCadenas <MarioCadenas@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant