Repository navigation
Bump httpclient, httpcore, avro and netty patch versions - #1070
Open
deepika-lalwani123 wants to merge 2 commits into
Open
deepika-lalwani123 wants to merge 2 commits into
deepika-lalwani123 wants to merge 2 commits into
Conversation
Image scanning of gcr.io/cdapio/cdap reports logback-classic and logback-core 1.2.11 inside the wrangler-service (DataPrep system app) jar. Wrangler does not declare logback and no wrangler code imports ch.qos.logback; it came in only as a compile dependency of io.cdap.cdap:cdap-etl-core (confirmed with dependency:tree, the only path). CDAP provides the logging backend at runtime, so the jar does not need its own copy. Versions: - logback-classic / logback-core 1.2.11 -> not packaged (exclusion of ch.qos.logback:* on cdap-etl-core in wrangler-service) - logback-classic 1.2.13 added at test scope only (logback.version in wrangler-service), declared before hadoop-mapreduce-client-core so it stays the SLF4J binding for unit tests; without it slf4j-reload4j binds and FileTypeDetectorTest fails with ExceptionInInitializerError Bugs: Plugins side done for b/578430422, b/578585447, b/578633383, b/578635398, b/578643563, b/578657694, b/578688736 (the logback CVEs fixed only in 1.3.x/1.5.x stay blocked by the Platform logback exception). Risk: low. Only the packaged jar list changes; logging in the app goes through slf4j to the CDAP-provided backend as for other plugins. Testing: JDK 8, Checkstyle on (0 violations). mvn clean verify -pl wrangler-service: Tests run: 17, Failures: 0, Errors: 0, Skipped: 6 (same as develop). dependency:tree -Dincludes=ch.qos.logback on wrangler-service shows only logback-classic/core 1.2.13 at test scope. unzip -l of wrangler-service-4.12.0-SNAPSHOT.jar: lib/ no longer has logback-classic-1.2.11.jar or logback-core-1.2.11.jar; no other lib/ change. DataPrep sandbox logging check (P3) not run here.
Patch-level bumps for CVEs that image scanning of gcr.io/cdapio/cdap reports in the wrangler-service and wrangler-transform jars (httpclient 4.5.3, avro 1.11.3). httpcore was not pinned: it resolved to 4.4.13 (via google-cloud-spanner) in wrangler-service and 4.4.6 in wrangler-core / wrangler-transform; it is now managed at 4.4.16 to match httpclient 4.5.14. netty is used only at test scope in wrangler (netty-all, netty-http); the bump keeps the netty-bom import aligned with the cross-repo target and changes no packaged jar. Versions: - httpclient 4.5.3 -> 4.5.14 (httpclient.version, now also in root dependencyManagement) - httpcore 4.4.13 / 4.4.6 -> 4.4.16 (new httpcore.version, root dependencyManagement) - avro 1.11.3 -> 1.11.4 (avro.version); avro 1.11.4 also moves its jackson-core/databind/annotations from 2.14.2 to 2.14.3 - netty-bom 4.1.118.Final -> 4.1.140.Final (netty.version) Bugs: none close alone. Plugins (wrangler) side done for httpclient b/578423875 (also needs google-cloud GC-4 and Platform); the avro bugs also need KP-3 / DS-3. Risk: low. Same-line patch releases. avro 1.11.4 rejects untrusted java-class schema properties (CVE-2024-47561 fix); wrangler does not use avro reflect/specific classes from schema props. Testing: JDK 8, Checkstyle on (0 violations). mvn clean install (all modules): BUILD SUCCESS. Tests: API 31/0 fail, Proto 3/0, Core 456/0 (2 skipped), Storage 37/0, Service 17/0 (6 skipped, same as develop), Transform 2/0. dependency:tree -Dincludes=org.apache.httpcomponents,org.apache.avro on wrangler-core/-service/-transform: only httpclient 4.5.14, httpcore 4.4.16, avro 1.11.4 at compile scope. unzip -l: wrangler-service and wrangler-transform lib/ now have httpclient-4.5.14, httpcore-4.4.16, avro-1.11.4 (old jars gone).
This was referenced Nov 17, 2026
There was a problem hiding this comment.
Code Review
This pull request updates several dependency versions in the parent pom.xml (including Avro, Netty, and Apache HttpClient) and configures wrangler-service/pom.xml to exclude Logback from the runtime artifact while retaining it for unit tests. The feedback recommends centralizing the logback.version property in the parent pom.xml instead of defining it locally in the child module to prevent duplication and version drift.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump httpclient, httpcore, avro and netty patch versions
Repo: data-integrations/wrangler
Branch: vuln/wr-2-patch-httpclient-avro-netty → base develop (stacked)
Commit: aea07eb
Part of the CVE fixes for the CDAP 6.11.2 patch release (container image scanning of gcr.io/cdapio/cdap).
Patch-level bumps for CVEs that image scanning of gcr.io/cdapio/cdap
reports in the wrangler-service and wrangler-transform jars
(httpclient 4.5.3, avro 1.11.3). httpcore was not pinned: it resolved
to 4.4.13 (via google-cloud-spanner) in wrangler-service and 4.4.6 in
wrangler-core / wrangler-transform; it is now managed at 4.4.16 to
match httpclient 4.5.14. netty is used only at test scope in wrangler
(netty-all, netty-http); the bump keeps the netty-bom import aligned
with the cross-repo target and changes no packaged jar.
Versions:
dependencyManagement)
dependencyManagement)
jackson-core/databind/annotations from 2.14.2 to 2.14.3
Findings: none are resolved by this PR alone. The wrangler plugins
changes are done for the httpclient finding (also needs
data-integrations/google-cloud#1636 and the CDAP platform); the avro
findings also need data-integrations/kafka-plugins#254 /
data-integrations/datastream-delta-plugins#157.
Risk: low. Same-line patch releases. avro 1.11.4 rejects untrusted
java-class schema properties (CVE-2024-47561 fix); wrangler does not
use avro reflect/specific classes from schema props.
Testing: JDK 8, Checkstyle on (0 violations).
mvn clean install (all modules): BUILD SUCCESS. Tests: API 31/0 fail,
Proto 3/0, Core 456/0 (2 skipped), Storage 37/0, Service 17/0
(6 skipped, same as develop), Transform 2/0.
dependency:tree -Dincludes=org.apache.httpcomponents,org.apache.avro
on wrangler-core/-service/-transform: only httpclient 4.5.14, httpcore
4.4.16, avro 1.11.4 at compile scope. unzip -l: wrangler-service and
wrangler-transform lib/ now have httpclient-4.5.14, httpcore-4.4.16,
avro-1.11.4 (old jars gone).