Skip to content

Add perfmark-api at compile scope to fix gRPC runtime NoClassDefFoundError - #1637

Merged
vikasrathee-cs merged 1 commit into
developfrom
fix-missing-perfmark-api-dependency
Nov 19, 2026
Merged

vikasrathee-cs merged 1 commit into
developfrom
fix-missing-perfmark-api-dependency

Conversation

@vishwasvaidya-cloudsufi

Copy link
Copy Markdown
Contributor

Summary

  • Issue: After Upgrade Bigtable HBase client to 2.x to remove shaded Hadoop 2.7.4 #1630 moved Bigtable to bigtable-hbase-2.x-hadoop (which relocates io.perfmark.*), gRPC plugins (Pub/Sub, Spanner) fail at runtime with NoClassDefFoundError: io/perfmark/PerfMark because io.grpc:grpc-core declares perfmark-api:0.23.0 at runtime scope while maven-bundle-plugin only embeds compile-scope JARs into lib/.
  • Fix: Explicitly add io.perfmark:perfmark-api:0.23.0 at compile scope in pom.xml so lib/perfmark-api-0.23.0.jar is packaged into the plugin bundle.
  • Testing: Verified lib/perfmark-api-0.23.0.jar is embedded in the built artifact and ran Pub/Sub required E2E tests against CDAP 6.11.1 (2/2 passed).

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the perfmark-api dependency (version 0.23.0) to the pom.xml file. This addition is necessary to ensure the library is correctly included at runtime by the maven-bundle-plugin, as it is a required dependency for io.grpc:grpc-core. I have no further feedback to provide.

@vikasrathee-cs
vikasrathee-cs merged commit 7e8a8d7 into develop Nov 19, 2026
35 checks passed
@vikasrathee-cs
vikasrathee-cs deleted the fix-missing-perfmark-api-dependency branch November 19, 2026 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Trigger unit test build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants