Skip to content

Bump snappy-java, httpclient and httpcore patch versions - #1633

Open
deepika-lalwani123 wants to merge 2 commits into
developfrom
vuln/gc-2-patch-snappy-httpclient
Open

deepika-lalwani123 wants to merge 2 commits into
developfrom
vuln/gc-2-patch-snappy-httpclient

Conversation

@deepika-lalwani123

@deepika-lalwani123 deepika-lalwani123 commented Nov 17, 2026 •

Copy link
Copy Markdown

Bump snappy-java, httpclient and httpcore patch versions

Stacked PR: this branch is built on top of #1632. Against develop the diff includes those commits; please review only the top commit e40376708a. Merge after #1632.

Repo: data-integrations/google-cloud
Branch: vuln/gc-2-patch-snappy-httpclient → base develop (stacked)
Commit: e403767
Part of the CVE fixes for the CDAP 6.11.2 patch release (container image scanning of gcr.io/cdapio/cdap).

Patch-level alignment with the cross-track targets used by the
CDAP platform PRs. No row of the current gcr.io/cdapio/cdap image scan points
at these top-level jars in google-cloud, but they are below the versions
used everywhere else and would re-open on the next scan:
snappy-java 1.1.10.5 is below the 1.1.10.12 target, and httpcore 4.4.14
(transitive) did not match httpclient. 4.5.14 / 4.4.16 are what
google-http-client-apache-v2 already uses, so nothing is downgraded.

Versions:

  • org.xerial.snappy:snappy-java 1.1.10.5 -> 1.1.10.12 (direct dependency)
  • org.apache.httpcomponents:httpclient 4.5.13 -> 4.5.14 (httpclient.version,
    now also in dependencyManagement)
  • org.apache.httpcomponents:httpcore 4.4.14 -> 4.4.16 (new httpcore.version
    property, managed in dependencyManagement)

Bugs: none (no scanned rows; prevents a re-open).

Risk: very low. Same-line patch releases.

Testing: JDK 8, Checkstyle on (0 violations).
mvn clean verify: 647 tests, 0 failures, 5 errors, 8 skipped; the 5
errors are the same cloud ITs as on develop (GCSConnectorTest x2,
SpannerConnectorTest x2, BigQueryConnectorTest: PERMISSION_DENIED on a
Linux workstation's ambient GCP project, no test credentials).
mvn dependency:tree: snappy-java 1.1.10.12, httpclient 4.5.14 and
httpcore 4.4.16 at compile scope; no other version of them on the
runtime classpath (httpcore-nio 4.4.5 stays test-only via cdap-unit-test).
unzip -l target/google-cloud-0.25.0-SNAPSHOT.jar: lib/httpclient-4.5.14.jar,
lib/httpcore-4.4.16.jar, lib/snappy-java-1.1.10.12.jar.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several dependencies in the pom.xml file, including upgrading httpclient to 4.5.14 and snappy-java to 1.1.10.12, adding httpcore 4.4.16, and introducing dependency management for both httpclient and httpcore. Furthermore, it adds exclusions for avro-ipc and avro-ipc-jetty to the avro-mapred dependency to prune unnecessary transitive dependencies. I have no feedback to provide.

@vishwasvaidya-cloudsufi vishwasvaidya-cloudsufi added the build Trigger unit test build label Nov 17, 2026
@vishwasvaidya-cloudsufi
vishwasvaidya-cloudsufi force-pushed the vuln/gc-2-patch-snappy-httpclient branch from e403767 to b1a8e3d Compare November 18, 2026 09:40
avro-mapred 1.11.4 pulls in avro-ipc and avro-ipc-jetty, which bring
velocity-engine-core 2.3 (shaded commons-io 2.8.0, CVE-2024-47554) and
org.tukaani:xz into lib/ of google-cloud-0.25.0-SNAPSHOT.jar, as seen in
the image scan of gcr.io/cdapio/cdap
(/opt/cdap/master/artifacts/google-cloud-*.jar/lib/velocity-engine-core-2.3.jar).

The plugins only use org.apache.avro.mapred.AvroKey and
org.apache.avro.mapreduce.* (BigQuery sink AvroOutputFormat /
AvroRecordWriter, Dataplex tests). Avro RPC and tether jobs, the only
users of avro-ipc, are not used. The Avro output codecs the plugins
allow are snappy and deflate (FileSetUtil), so dropping xz is safe.

Versions:
- org.apache.avro:avro-ipc 1.11.4 -> removed (exclusion on avro-mapred)
- org.apache.avro:avro-ipc-jetty 1.11.4 -> removed (exclusion on avro-mapred)
- velocity-engine-core 2.3 and xz 1.9 no longer packaged

Bugs: none closed alone. The other commons-io 2.8.0 copy (inside
format-avro-2.13.0.jar) is removed by hydrator-plugins HP-1.

Risk: very low. No plugin code path uses avro-ipc.

Testing: JDK 8, Checkstyle on (0 violations).
mvn clean verify: 647 tests, 0 failures, 5 errors, 8 skipped. The 5
errors are cloud ITs that pick up the Cloudtop's ambient GCP project and
fail with PERMISSION_DENIED (GCSConnectorTest x2, SpannerConnectorTest
x2, BigQueryConnectorTest); they fail the same way on develop. All other
unit tests pass, including AvroRecordWriterTest and
DataPlexOutputFormatProviderTest.
mvn dependency:tree: avro-mapred:1.11.4 has no children; avro-ipc,
avro-ipc-jetty, velocity-engine-core and xz are gone.
unzip -l target/google-cloud-0.25.0-SNAPSHOT.jar: lib/ has no avro-ipc*,
velocity-* or xz-* jar.
Patch-level alignment with the cross-track targets used by the
Platform CLs. No row of the current gcr.io/cdapio/cdap image scan points
at these top-level jars in google-cloud, but they are below the versions
used everywhere else and would re-open on the next scan:
snappy-java 1.1.10.5 is below the 1.1.10.12 target, and httpcore 4.4.14
(transitive) did not match httpclient. 4.5.14 / 4.4.16 are what
google-http-client-apache-v2 already uses, so nothing is downgraded.

Versions:
- org.xerial.snappy:snappy-java 1.1.10.5 -> 1.1.10.12 (direct dependency)
- org.apache.httpcomponents:httpclient 4.5.13 -> 4.5.14 (httpclient.version,
  now also in dependencyManagement)
- org.apache.httpcomponents:httpcore 4.4.14 -> 4.4.16 (new httpcore.version
  property, managed in dependencyManagement)

Bugs: none (no scanned rows; prevents a re-open).

Risk: very low. Same-line patch releases.

Testing: JDK 8, Checkstyle on (0 violations).
mvn clean verify: 647 tests, 0 failures, 5 errors, 8 skipped; the 5
errors are the same cloud ITs as on develop (GCSConnectorTest x2,
SpannerConnectorTest x2, BigQueryConnectorTest: PERMISSION_DENIED on the
Cloudtop's ambient GCP project, no test credentials).
mvn dependency:tree: snappy-java 1.1.10.12, httpclient 4.5.14 and
httpcore 4.4.16 at compile scope; no other version of them on the
runtime classpath (httpcore-nio 4.4.5 stays test-only via cdap-unit-test).
unzip -l target/google-cloud-0.25.0-SNAPSHOT.jar: lib/httpclient-4.5.14.jar,
lib/httpcore-4.4.16.jar, lib/snappy-java-1.1.10.12.jar.
@vishwasvaidya-cloudsufi
vishwasvaidya-cloudsufi force-pushed the vuln/gc-2-patch-snappy-httpclient branch from b1a8e3d to 85be4fa Compare November 19, 2026 09:34

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Trigger unit test build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants