Repository navigation
Import jackson-bom 2.18.12 instead of pinning jackson-databind - #239
Open
deepika-lalwani123 wants to merge 1 commit into
Open
deepika-lalwani123 wants to merge 1 commit into
deepika-lalwani123 wants to merge 1 commit into
Conversation
The image scan of gcr.io/cdapio/cdap reports 14 rows (3 jackson-core, 11 jackson-databind CVEs) against /opt/cdap/master/artifacts/amazon-s3-plugins-*.jar/lib/jackson-*-2.13.4*. Only jackson-databind was pinned (2.13.4.2), so jackson-core and jackson-annotations stayed at 2.13.4 and jackson-dataformat-cbor (from the AWS SDK) at 2.12.6. Import com.fasterxml.jackson:jackson-bom so every Jackson module the plugin packages is aligned on one version. Versions: - jackson-databind 2.13.4.2 -> 2.18.12 (jackson.databind.version replaced by jackson.version + jackson-bom import in root dependencyManagement) - jackson-core / jackson-annotations 2.13.4 -> 2.18.12 (via the BOM) - jackson-dataformat-cbor 2.12.6 -> 2.18.12 (via the BOM; comes from aws-java-sdk-core 1.12.552) Bugs: none completed by this PR alone (plan S3-1: 0 / 0); it removes the amazon-s3-plugins copies of the jackson-core / jackson-databind CVEs, which also need the other plugin repos. Risk: low. Jackson 2.15+ adds default stream read limits (max string length 20M, nesting depth 1000) and 2.18 changes some property introspection; the plugin only uses Jackson through the AWS SDK v1, which supports 2.18. Testing: JDK 8. mvn -B clean verify: BUILD SUCCESS, Checkstyle 0 violations, S3ConnectorTest, S3BatchSourceTest, S3PathTest: Tests run: 8, Failures: 0, Errors: 0, Skipped: 1 (S3ConnectorTest is skipped by Assume without AWS credentials). mvn dependency:tree -Dincludes=com.fasterxml.jackson*: develop shows databind 2.13.4.2, core/annotations 2.13.4, cbor 2.12.6; this branch shows only 2.18.12 (compile, provided and test). unzip -l of target/amazon-s3-plugins-1.22.0-SNAPSHOT.jar: lib/jackson-annotations, -core, -databind and -dataformat-cbor are all 2.18.12. e2e-tests profile not run (needs AWS credentials).
There was a problem hiding this comment.
Code Review
This pull request updates the Jackson dependency management in the pom.xml file. It replaces the explicit version of jackson-databind with the jackson-bom Bill of Materials (BOM) version 2.18.12 in the <dependencyManagement> section, allowing Jackson dependencies to be managed consistently. I have no feedback to provide as there are no review comments to evaluate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Import jackson-bom 2.18.12 instead of pinning jackson-databind
Repo: data-integrations/amazon-s3-plugins
Branch: vuln/s3-1-jackson-bom → base develop
Commit: 031aa8d
Part of the CVE fixes for the CDAP 6.11.2 patch release (container image scanning of gcr.io/cdapio/cdap).
The image scan of gcr.io/cdapio/cdap reports 14 rows (3 jackson-core,
11 jackson-databind CVEs) against
/opt/cdap/master/artifacts/amazon-s3-plugins-.jar/lib/jackson--2.13.4*.
Only jackson-databind was pinned (2.13.4.2), so jackson-core and
jackson-annotations stayed at 2.13.4 and jackson-dataformat-cbor (from
the AWS SDK) at 2.12.6.
Import com.fasterxml.jackson:jackson-bom so every Jackson module the
plugin packages is aligned on one version.
Versions:
replaced by jackson.version + jackson-bom import in root
dependencyManagement)
aws-java-sdk-core 1.12.552)
This PR removes the amazon-s3-plugins copies of the jackson-core /
jackson-databind CVEs; resolving them completely also requires updating
the other plugin repos.
Risk: low. Jackson 2.15+ adds default stream read limits (max string
length 20M, nesting depth 1000) and 2.18 changes some property
introspection; the plugin only uses Jackson through the AWS SDK v1,
which supports 2.18.
Testing: JDK 8. mvn -B clean verify: BUILD SUCCESS, Checkstyle 0
violations, S3ConnectorTest, S3BatchSourceTest, S3PathTest: Tests
run: 8, Failures: 0, Errors: 0, Skipped: 1 (S3ConnectorTest
is skipped by Assume without AWS credentials).
mvn dependency:tree -Dincludes=com.fasterxml.jackson*: develop shows
databind 2.13.4.2, core/annotations 2.13.4, cbor 2.12.6; this branch
shows only 2.18.12 (compile, provided and test). unzip -l of
target/amazon-s3-plugins-1.22.0-SNAPSHOT.jar: lib/jackson-annotations,
-core, -databind and -dataformat-cbor are all 2.18.12. e2e-tests
profile not run (needs AWS credentials).