Skip to content

Import jackson-bom 2.18.12 instead of pinning jackson-databind - #239

Open
deepika-lalwani123 wants to merge 1 commit into
developfrom
vuln/s3-1-jackson-bom
Open

deepika-lalwani123 wants to merge 1 commit into
developfrom
vuln/s3-1-jackson-bom

Conversation

@deepika-lalwani123

@deepika-lalwani123 deepika-lalwani123 commented Nov 17, 2026 •

Copy link
Copy Markdown

Import jackson-bom 2.18.12 instead of pinning jackson-databind
Repo: data-integrations/amazon-s3-plugins
Branch: vuln/s3-1-jackson-bom → base develop
Commit: 031aa8d
Part of the CVE fixes for the CDAP 6.11.2 patch release (container image scanning of gcr.io/cdapio/cdap).

The image scan of gcr.io/cdapio/cdap reports 14 rows (3 jackson-core,
11 jackson-databind CVEs) against
/opt/cdap/master/artifacts/amazon-s3-plugins-.jar/lib/jackson--2.13.4*.
Only jackson-databind was pinned (2.13.4.2), so jackson-core and
jackson-annotations stayed at 2.13.4 and jackson-dataformat-cbor (from
the AWS SDK) at 2.12.6.

Import com.fasterxml.jackson:jackson-bom so every Jackson module the
plugin packages is aligned on one version.

Versions:

  • jackson-databind 2.13.4.2 -> 2.18.12 (jackson.databind.version
    replaced by jackson.version + jackson-bom import in root
    dependencyManagement)
  • jackson-core / jackson-annotations 2.13.4 -> 2.18.12 (via the BOM)
  • jackson-dataformat-cbor 2.12.6 -> 2.18.12 (via the BOM; comes from
    aws-java-sdk-core 1.12.552)

This PR removes the amazon-s3-plugins copies of the jackson-core /
jackson-databind CVEs; resolving them completely also requires updating
the other plugin repos.

Risk: low. Jackson 2.15+ adds default stream read limits (max string
length 20M, nesting depth 1000) and 2.18 changes some property
introspection; the plugin only uses Jackson through the AWS SDK v1,
which supports 2.18.

Testing: JDK 8. mvn -B clean verify: BUILD SUCCESS, Checkstyle 0
violations, S3ConnectorTest, S3BatchSourceTest, S3PathTest: Tests
run: 8, Failures: 0, Errors: 0, Skipped: 1 (S3ConnectorTest
is skipped by Assume without AWS credentials).
mvn dependency:tree -Dincludes=com.fasterxml.jackson*: develop shows
databind 2.13.4.2, core/annotations 2.13.4, cbor 2.12.6; this branch
shows only 2.18.12 (compile, provided and test). unzip -l of
target/amazon-s3-plugins-1.22.0-SNAPSHOT.jar: lib/jackson-annotations,
-core, -databind and -dataformat-cbor are all 2.18.12. e2e-tests
profile not run (needs AWS credentials).

The image scan of gcr.io/cdapio/cdap reports 14 rows (3 jackson-core,
11 jackson-databind CVEs) against
/opt/cdap/master/artifacts/amazon-s3-plugins-*.jar/lib/jackson-*-2.13.4*.
Only jackson-databind was pinned (2.13.4.2), so jackson-core and
jackson-annotations stayed at 2.13.4 and jackson-dataformat-cbor (from
the AWS SDK) at 2.12.6.

Import com.fasterxml.jackson:jackson-bom so every Jackson module the
plugin packages is aligned on one version.

Versions:
- jackson-databind 2.13.4.2 -> 2.18.12 (jackson.databind.version
  replaced by jackson.version + jackson-bom import in root
  dependencyManagement)
- jackson-core / jackson-annotations 2.13.4 -> 2.18.12 (via the BOM)
- jackson-dataformat-cbor 2.12.6 -> 2.18.12 (via the BOM; comes from
  aws-java-sdk-core 1.12.552)

Bugs: none completed by this PR alone (plan S3-1: 0 / 0); it removes
the amazon-s3-plugins copies of the jackson-core / jackson-databind
CVEs, which also need the other plugin repos.

Risk: low. Jackson 2.15+ adds default stream read limits (max string
length 20M, nesting depth 1000) and 2.18 changes some property
introspection; the plugin only uses Jackson through the AWS SDK v1,
which supports 2.18.

Testing: JDK 8. mvn -B clean verify: BUILD SUCCESS, Checkstyle 0
violations, S3ConnectorTest, S3BatchSourceTest, S3PathTest: Tests
run: 8, Failures: 0, Errors: 0, Skipped: 1 (S3ConnectorTest
is skipped by Assume without AWS credentials).
mvn dependency:tree -Dincludes=com.fasterxml.jackson*: develop shows
databind 2.13.4.2, core/annotations 2.13.4, cbor 2.12.6; this branch
shows only 2.18.12 (compile, provided and test). unzip -l of
target/amazon-s3-plugins-1.22.0-SNAPSHOT.jar: lib/jackson-annotations,
-core, -databind and -dataformat-cbor are all 2.18.12. e2e-tests
profile not run (needs AWS credentials).

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Jackson dependency management in the pom.xml file. It replaces the explicit version of jackson-databind with the jackson-bom Bill of Materials (BOM) version 2.18.12 in the <dependencyManagement> section, allowing Jackson dependencies to be managed consistently. I have no feedback to provide as there are no review comments to evaluate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants