Skip to content

fix(ci): allow the skills survey storage label in the secret scan [PANL-013] - #34

Merged
darthrootbeer merged 1 commit into
mainfrom
fix/gitleaks-storage-key-false-alarm
Oct 26, 2026
Merged

darthrootbeer merged 1 commit into
mainfrom
fix/gitleaks-storage-key-false-alarm

Conversation

@darthrootbeer

Copy link
Copy Markdown
Owner

Context

The weekly full-history secret scan has failed four Mondays in a row (Oct 5, 12, 19, 26), so main shows a red status on the repo page. It flags one line in an earlier version of the skills survey page: var KEY = "ja-skills-survey-v1", a browser storage label, not a credential. Push and pull request scans stay green because they only read new changes. Ticket: PANL-013.

Changes

One file, .gitleaks.toml: the allowlist now also ignores the text ja-skills-survey-v1, matched by text and not by commit hash so it survives squash merges. The existing YOUR_API_KEY allowance is unchanged. No other scan rule changes.

Checks

  • README.md and ROADMAP.md describe what is in the tree after this change, and nothing that is not
  • python3 .github/scripts/safety_scan.py --range origin/main...HEAD is clean
  • No new scripts, so no new tests
  • Private gate: the cet-gate.sh script was not found on this machine, so it was not run

Verification after merge: trigger the workflow by hand on main and confirm the safety job passes.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Bihc4e3Pg6Ago5K1xfMbe5

  • Docs updated

@darthrootbeer
darthrootbeer merged commit 233865c into main Oct 26, 2026
6 checks passed
@darthrootbeer
darthrootbeer deleted the fix/gitleaks-storage-key-false-alarm branch October 26, 2026 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant