Repository navigation
Conversation
The JSON operator group matched a bare ? and ?| before the geometric group, so ?#, ?-, ?-| and ?|| were split into separate tokens.
This was referenced Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JSON/vector operator group in
Beautify.pmmatches a bare?and?|before the geometric group, so the geometric operators?#,?-,?-|and?||are split:and
?||comes out as?| |, which PostgreSQL parses as a different operator. This removes those two alternatives from the JSON group so the existing geometric entries match; a bare?still reaches the generic operator group. Addedt/test-files/ex88.sqland updated thegeometry.sqlregression golden, which had recorded the split operators. Checked with PostgreSQL's parser (pglast) over its own regression SQL files: 11 statements that changed meaning are fixed and none are broken. One visible change: a placeholder written?-1is now kept as?- 1, which is how PostgreSQL reads it.prove -l t/andt/regress_test.plpass.Written with AI assistance (Claude); I have reviewed the change.