Repository navigation
Develop - #48
Merged
Merged
Develop#48
Conversation
Collapses develop's full history (324 commits ahead of main at the time of this squash) into one commit. Individual commit history is preserved in the prior develop ref and reflog for reference, but this branch no longer carries it going forward. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M2C3HoaVYXFeC5S97WxUWe
QueueSlug.Default's value changed from 'default' to 'DefaultQueue' in the Heartbeat queue split, but four call sites still hardcoded the old string instead of importing the constant: - generateThumbnail.ts (MediaVideos) and generateThumbnails.ts (MediaDocuments) queued real jobs against a queue name that no longer matches any configured queue, so they'd never be picked up by autoRun — a real bug, not just a stale test fixture. - enqueueBilingualTranslation.test.ts and enqueueAutoTranslate.test.ts asserted against the literal and were failing after the rename. All four now reference QueueSlug.Default so this can't drift again. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M2C3HoaVYXFeC5S97WxUWe
…rker - Dockerfile: NODE_ENV is now an ARG (default production), threaded through builder/app/worker instead of being hardcoded to production in every stage. ci.yml's docker-app-development job passes --build-arg NODE_ENV=development, so PRs against develop build images that actually reflect a development environment; PRs against main keep the default production. storybook stays hardcoded production — it's an independent static build not gated by base branch. - package.json: start:job-runner renamed to start:worker, matching the Dockerfile's worker target/stage name (the stage itself was already named worker; only the script lagged behind). - package.json: added serve:storybook (serve -s dist -l 3000) as the documented definition of the storybook stage's serve command. The Dockerfile CMD still invokes the serve binary directly rather than via pnpm run serve:storybook — tested locally, and pnpm run in that stage (no node_modules/lockfile, only dist is copied in) resolves and installs the entire workspace at container startup instead of serving immediately. Verified: docker build --check passes for app/worker/storybook; storybook target builds and serves 200 in ~3s; a minimal Dockerfile reproduction confirms the ARG default/override both thread through as expected. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M2C3HoaVYXFeC5S97WxUWe
…, simplify slug field
- Remove next.cache-handler.ts (Redis-backed Cache Components handler)
along with its only dependency, @trieb.work/nextjs-turbo-redis-cache.
Also drops two other unused dependencies caught in the same pass:
react-markdown and server-only (both had zero live imports left in
the codebase — only a commented-out reference and a doc-comment
mention of server-only remained).
- proxy.ts: redirect resume.heene.{io,dev,review,nexus,local} to the
corresponding daniel.heene.* /resume/[slug] path. Also removes a
stray unused `io` import (next/dist internals) left over from
in-progress debugging — never referenced anywhere in the file.
- ResumeDocuments: replaces the auto-slugifying SlugField with a plain
read-only text field; slug is apparently now set elsewhere rather
than derived from title on save. src/types/payload.ts's
ResumeDocumentData.slug becomes optional/nullable to match
(payload generate:types output).
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01M2C3HoaVYXFeC5S97WxUWe
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.