Repository navigation
fix(umami): drop console.error noise from Umami unreachable paths - #109
Merged
Merged
Conversation
Localhost values in .env.test are format-valid placeholders — treating them as real URLs causes consumers (UmamiWidget, ServiceStatus) to attempt network connections to addresses that don't exist in test and E2E environments, filling logs with ECONNREFUSED noise. readExternalUrl() now returns undefined for any localhost/127.0.0.1/::1 URL, so those consumers skip their network calls without needing per-consumer guards.
Remove console.error from UmamiWidget.data.ts login/verify/fetch catch blocks and from the /stats proxy route — Umami being unreachable is expected in test/E2E environments and all paths already return null/204/502 gracefully. Revert the runtimeConfig localhost-filter approach (wrong layer).
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Reviewed by free · Input: 181.8K · Output: 2.7K · Cached: 34.6K |
danielheene-website-release Bot
pushed a commit
that referenced
this pull request
Oct 9, 2026
## [1.12.3](v1.12.2...v1.12.3) (2026-10-09) ### Bug Fixes * **umami:** drop console.error noise from Umami unreachable paths ([#109](#109)) ([4b352f0](4b352f0))
|
🎉 This PR is included in version 1.12.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
console.errorfromUmamiWidget.data.tslogin, verify, and fetch catch blocks — Umami being down is expected in test/E2E environments, all paths already returnnullgracefully/stats/[...path]proxy route to prevent Next.js from logging "Failed to proxy" on upstream fetch failures; returns 502 instead of an unhandled throwcatch(no binding) since the error value is not usedTest plan
Error logging in to UmamiorFailed to proxyspam