Repository navigation
Make the server coroutine stack size a build setting - #148
Merged
Merged
Conversation
The default stays 64 KiB, and AddressSanitizer builds still use at least 256 KiB, so a deployment can choose a smaller stack without changing shared memory.
The statistics check was reading a backlog that can skip a retired slot, and the recovery test was walking the server channel map from another thread.
…buffers on recovery. The lock only existed so tests could inspect server state from another thread. On Android the buffer count can outlive the memfd, which left the recovered telemetry publisher unable to attach.
A late subscriber can see a skipped sequence in messages that were already published, and that backlog can arrive after the first read. Compare a message that shows up only after the subscriber has waited.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
subspace.coroutine_stack_size(bytes = N),--//:coroutine_stack_size=N, or-DSUBSPACE_COROUTINE_STACK_SIZE=N.Nmust be a positive multiple of 4096. Clients do not need the same value, because this is process memory rather than shared memory.Test plan
bazelisk test //common/async:async_test //shadow:shadow_test --config=macos_arm64bazelisk test //common/async:async_test --//:coro_backend=asio --config=macos_arm64--//:coroutine_stack_size=16384shows up as-DSUBSPACE_COROUTINE_STACK_SIZE=16384on the server compile--//:coroutine_stack_size=1000is rejected at analysis time