Repository navigation
feat: Support for RFC 9651 types in signature parameters - #201
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #201 +/- ##
==========================================
- Coverage 98.02% 97.98% -0.05%
==========================================
Files 23 23
Lines 1624 1635 +11
==========================================
+ Hits 1592 1602 +10
- Misses 32 33 +1 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds support for the
Display StringandDateStructured Fields types introduced by RFC 9651 in HTTP Message Signatures extension parameters.Applications can now explicitly use
httpsig.DisplayStringandtime.Timewithhttpsig.WithParameter(). Both types are also supported by theAccept-Signatureheader builder and parser.Potential breaking change: Previously, decoded Display Strings were returned as ordinary Go strings. They are now returned as
httpsig.DisplayString, which may require adjustments in applications relying on type assertions.Please note: HMS implementations based on RFC 8941 may not accept these types, so interoperability depends on the capabilities of the communicating parties.