Repository navigation
fix: Parsing dictionary fields directly for key components - #200
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #200 +/- ##
==========================================
+ Coverage 97.97% 98.02% +0.05%
==========================================
Files 23 23
Lines 1626 1624 -2
==========================================
- Hits 1593 1592 -1
+ Misses 33 32 -1 ☔ View full report in Codecov by Harness. |
key components
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When selecting a Structured Fields Dictionary member using the
keycomponent parameter, the serializer previously attempted to parse the field as a List first.For example, given the HTTP field:
X-Test: aand the component identifier
"x-test";key="a", the expected canonicalized value is?1, sincearepresents a Boolean true Dictionary member. However, the List parser also acceptsa, causing the serializer to incorrectly reject the field instead of producing the expected value.This change parses the field directly as a Dictionary whenever the
keyparameter is present, as required by RFC 9421 Section 2.1.2. The existing parsing behavior for other Structured Fields remains unchanged.