Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions accept_signature_builder.go
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@ func (asb *AcceptSignatureBuilder) Build(

func (asb *AcceptSignatureBuilder) setIdentifiers(identifiers []*componentIdentifier) {
asb.identifiers = identifiers
asb.wantContentDigest = false

for _, identifier := range asb.identifiers {
if identifier.Value == componentIdentifierContentDigest {
Expand Down
13 changes: 13 additions & 0 deletions accept_signature_builder_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,19 @@ func TestAcceptSignatureBuilderBuild(t *testing.T) {
assert.Empty(t, hdr.Values(headerWantContentDigest))
},
},
"Want-Content-Digest is omitted after overriding covered components": {
opts: []AcceptSignatureOption{
WithComponents("@status", "content-digest"),
WithComponents("@method"),
},
assert: func(t *testing.T, err error, hdr http.Header) {
t.Helper()

require.NoError(t, err)
assert.Equal(t, `sig=("@method");created;expires`, hdr.Get(headerAcceptSignature))
assert.Empty(t, hdr.Values(headerWantContentDigest))
},
},
"Accept-Signature and Want-Content-Digest headers are added with default algorithms": {
opts: []AcceptSignatureOption{
WithSignatureAlgorithm(EcdsaP256Sha256),
Expand Down
Loading