Skip to content

refactor: Signature input handling refactored - #160

Merged
dadrus merged 5 commits into
mainfrom
refactor/signature_parameters
Oct 20, 2026
Merged

dadrus merged 5 commits into
mainfrom
refactor/signature_parameters

Conversation

@dadrus

@dadrus dadrus commented Oct 20, 2026

Copy link
Copy Markdown
Owner

This PR replaces the internal signatureParameters type with signatureInput, using httpsfv.InnerList as the single source of truth for signature parameters.

It introduces typed accessors, separates signature input construction from parsing and validation, and adapts the signing and verification logic accordingly.

@codecov

codecov Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.41270% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.39%. Comparing base (b00841b) to head (db72bcc).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
signer.go 89.47% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #160      +/-   ##
==========================================
- Coverage   94.41%   94.39%   -0.03%     
==========================================
  Files          19       19              
  Lines        1342     1337       -5     
==========================================
- Hits         1267     1262       -5     
  Misses         38       38              
  Partials       37       37              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@dadrus
dadrus merged commit 21e796c into main Oct 20, 2026
10 checks passed
@dadrus
dadrus deleted the refactor/signature_parameters branch October 20, 2026 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant