Skip to content

refactor: Made signature base explicit - #157

Merged
dadrus merged 3 commits into
mainfrom
refactor/explicit_signature_base
Oct 18, 2026
Merged

dadrus merged 3 commits into
mainfrom
refactor/explicit_signature_base

Conversation

@dadrus

@dadrus dadrus commented Oct 18, 2026

Copy link
Copy Markdown
Owner

This PR extracts signature base construction and serialization into a dedicated signatureBase type, replacing signatureParameters.toSignatureBase() with newSignatureBase().

It also adds a method to retrieve the canonicalized covered components, laying the groundwork for exposing them as part of the signature verification result in a future PR.

@codecov

codecov Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.32787% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.41%. Comparing base (d3db29a) to head (3e87a72).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
signature_base.go 82.97% 4 Missing and 4 partials ⚠️
signer.go 71.42% 1 Missing and 1 partial ⚠️
verifier.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #157      +/-   ##
==========================================
- Coverage   94.47%   94.41%   -0.07%     
==========================================
  Files          18       19       +1     
  Lines        1322     1342      +20     
==========================================
+ Hits         1249     1267      +18     
- Misses         37       38       +1     
- Partials       36       37       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@dadrus
dadrus merged commit 307bb84 into main Oct 18, 2026
10 checks passed
@dadrus
dadrus deleted the refactor/explicit_signature_base branch October 18, 2026 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant