Preserve approval of the same commit across publication recovery - #21
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A formal approval submitted after push but before publication recovery was ignored because the dispatcher recorded
publishedAtonly after updating the PR description. The approved commit was unchanged, yet retrying publication made the review appear too old to authorize merging.Accept the latest submitted, non-revoked approval for the exact verified PR commit regardless of when description publication completes. Keep timestamp gating for plain merge comments, which do not identify a commit. Preserve allowed-author and repository-permission checks, outstanding change-request handling, GitHub merge-readiness checks, and SHA-pinned merge requests.
Update the configuration/runtime references, architecture, workflow diagram 7 and its explanation, advanced state documentation, and changelog. Clarify that legacy publication timestamps establish a window for merge comments; formal reviews remain bound to the verified commit.
Validation:
npm run check: lint, typecheck, 214 tests, native TUI rendering, and build.This is a separate PR based on
develafter the merge of #20. It does not deploy to the test server.