Skip to content

perf(cli): optimize html entity decoding with byte slice lookahead - #661

Merged
d-oit merged 2 commits into
mainfrom
perf/optimize-html-entity-decoding-1625669646136469838
Oct 9, 2026
Merged

d-oit merged 2 commits into
mainfrom
perf/optimize-html-entity-decoding-1625669646136469838

Conversation

@d-oit

@d-oit d-oit commented Oct 9, 2026

Copy link
Copy Markdown
Owner

Optimize decode_entities in cli/src/providers/direct_fetch.rs by replacing char_indices().peekable() character iterator clones with byte slice lookahead (as_bytes() and position(|&c| c == b';')). Benchmark results (cli/benches/decode_entities_bench.rs) confirm a ~41% latency reduction (609 ns vs 1.03 µs on inputs with entities, and 5.9 µs vs 10.1 µs on long text).


PR created automatically by Jules for task 1625669646136469838 started by @d-oit

@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel

vercel Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
do-web-doc-resolover Ready Ready Preview Oct 9, 2026 11:24am UTC

@codacy-production

Copy link
Copy Markdown
Contributor

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@d-oit
d-oit merged commit 1c50d72 into main Oct 9, 2026
47 checks passed
@d-oit
d-oit deleted the perf/optimize-html-entity-decoding-1625669646136469838 branch October 9, 2026 12:08

This branch was successfully deployed

1 active deployment
Preview — 1767c3c9 Deployed Oct 9, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant