Skip to content

feat(ux): add tooltip title to right panel close button - #920

Open
d-oit wants to merge 1 commit into
mainfrom
jules-18373660895656848417-e3d0bfce
Open

d-oit wants to merge 1 commit into
mainfrom
jules-18373660895656848417-e3d0bfce

Conversation

@d-oit

@d-oit d-oit commented Oct 9, 2026 •

Copy link
Copy Markdown
Owner

Adds title attribute to PanelCloseButton component matching its aria-label, ensuring native tooltip on hover alongside screen-reader accessibility.


PR created automatically by Jules for task 18373660895656848417 started by @d-oit


📝 Summary by GitNexus

Summary

A localized studio UI change with a critical blast classification, although the changed file is rated low risk.

🔴 CRITICAL blast radius. A UI change adds a tooltip title to the right panel close button and reaches five dependents.

The changed symbol, PanelCloseButton, is in src/components/studio/right-panel-close-button.tsx; the related test is src/components/studio/right-panel.test.tsx. The graph places the impact in Studio and traces it through 14 affected flows.

Review the close button change and the right panel tests, then check the downstream callers represented in the blast report. There are no HIGH or CRITICAL risk files and no cross-repo consumers.

Added by GitNexus for PR #920. Edit freely — this block is replaced on the next review, everything above it is left untouched.

@vercel

vercel Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
do-knowledge-studio Ready Ready Preview, v0 Oct 9, 2026 4:09am UTC

@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added config tests Related to automated/manual tests labels Oct 9, 2026
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Blocked merge diagnosis — blocked
⏳ Check run(s) still in progress: ["Codacy Static Code Analysis","labeler","Dependency Advisory Audit","Trivy Filesystem Security Scan","Secret Detection","Infrastructure as Code Security","Shell Script Security Analysis","Diagnose Blocked Merge State","Detect Changes","commitlint","GitNexus","Analyze (actions)","Analyze (javascript-typescript)"]

@nexus-check

nexus-check Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor
Akon Labs

GitNexus Review · PR #920

1 issue found across 1 file.

Summary

A localized studio UI change with a critical blast classification, although the changed file is rated low risk.

🔴 CRITICAL blast radius. A UI change adds a tooltip title to the right panel close button and reaches five dependents.

The changed symbol, PanelCloseButton, is in src/components/studio/right-panel-close-button.tsx; the related test is src/components/studio/right-panel.test.tsx. The graph places the impact in Studio and traces it through 14 affected flows.

Review the close button change and the right panel tests, then check the downstream callers represented in the blast report. There are no HIGH or CRITICAL risk files and no cross-repo consumers.

Full detail lives in the GitNexus check run for this commit.

@nexus-check

nexus-check Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

🤖 Agent context for GitNexus Review · PR #920

This comment carries deterministic graph detail for coding agents and reviewers who want the receipts — the main review comment carries the human summary.

🔴 CRITICAL blast radius — this change reaches 5 downstream symbols across 1 module; this lands on a critical surface, so review the dependents carefully before merging. (driven by dependent/module count, not file risk)

Blast Level Dependents Modules Files
🔴 CRITICAL 5 1 2

What changed

Symbol Changes (1)
Kind Symbol Location
Function PanelCloseButton src/components/studio/right-panel-close-button.tsx:4
Changed Files (2)
File Status
src/components/studio/right-panel-close-button.tsx 🟡 modified
src/components/studio/right-panel.test.tsx 🟡 modified

What it affects

Architecture Impact

Module Hits Direct
Studio 6 🟢

Blast Radius

Depth Count
d1 (direct) 3
d2 (indirect) 1
d3 (transitive) 1
Direct dependents (d1)
  • src/components/studio/right-panel.tsx:177 · SearchPanel
  • src/components/studio/right-panel.tsx:316 · InspectorPanel
  • src/components/studio/right-panel-citations.tsx:26 · CitationsPanel
Indirect dependents (d2)
  • src/components/studio/right-panel.tsx:459 · RightPanel
Transitive dependents (d3)
  • src/components/studio/app-shell.tsx:219 · AppShell
Prompt for AI agents (1 issue)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.

<file name="src/components/studio/right-panel-close-button.tsx">

<violation number="1" location="src/components/studio/right-panel-close-button.tsx:5">
P2: PanelCloseButton signature changed — callers not verified — 'PanelCloseButton' changed its signature (a destructured parameter changed; compatibility: uncertain). **Unverified** — no call site was confirmed to break: GitNexus could not decide whether this change is compatible with existing callers. Before: 'export const PanelCloseButton = ({ onClose }: { onClose: () => void }) => (' After: 'export const PanelCloseButton = ({ onClose, title = CLOSE_PANEL_LABEL, }: { onClose: () => void title?: string }) => (' Files the indexed graph records as calling it: ', 's'. _Dependents come from the indexed base-branch graph; check whether they still match the new
</violation>

</file>

export const CLOSE_PANEL_LABEL = 'Close panel'

export const PanelCloseButton = ({ onClose }: { onClose: () => void }) => (
export const PanelCloseButton = ({

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Warning — PanelCloseButton signature changed — callers not verified

PanelCloseButton changed its signature (a destructured parameter changed; compatibility: uncertain). Unverified — no call site was confirmed to break: GitNexus could not decide whether this change is compatible with existing callers.

Before: export const PanelCloseButton = ({ onClose }: { onClose: () =&gt; void }) =&gt; (
After: export const PanelCloseButton = ({ onClose, title = CLOSE_PANEL_LABEL, }: { onClose: () =&gt; void title?: string }) =&gt; (

Files the indexed graph records as calling it: ``, s.

Dependents come from the indexed base-branch graph; check whether they still match the new signature.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At src/components/studio/right-panel-close-button.tsx, line 5:

<comment>'PanelCloseButton' changed its signature (a destructured parameter changed; compatibility: uncertain). **Unverified** — no call site was confirmed to break: GitNexus could not decide whether this change is compatible with existing callers. Before: 'export const PanelCloseButton = ({ onClose }: { onClose: () => void }) => (' After: 'export const PanelCloseButton = ({ onClose, title = CLOSE_PANEL_LABEL, }: { onClose: () => void title?: string }) => (' Files the indexed graph records as calling it: ', 's'. _Dependents come from the indexed base-branch graph; check whether they still match the new</comment>

<context>Enclosing symbol: PanelCloseButton.</context>

Why this matters: GitNexus proved this from your code graph — a caller or contract relies on what changed here. · contract-drift

@codacy-production

Copy link
Copy Markdown
Contributor

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

This branch was successfully deployed

1 active deployment
Preview — e55545a3 Deployed Oct 9, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

config tests Related to automated/manual tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant