gha: fix broken llvm-cov CI jobs - #412
Open
cyphar wants to merge 4 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
cyphar
changed the title
cyphar
force-pushed
the
gha-workflow-dispatch
branch
from
September 3, 2026 05:05
1fc7b16 to
daaba41
Compare
Owner
Author
|
This now includes a workaround for taiki-e/cargo-llvm-cov#520. |
Rust nightly-2026-07-30 enabled the v2 build-dir layout for builds, which /is/ supported by cargo-llvm-cov and cargo-nextest but unfortunately the way they handle it is not incompatible. cargo-llvm-cov relies on a special "fingerprint" directory being present to look for a v2 build-dir layout but "cargo-nextest archive" does not include that directory in the archive (instead the relevant information is stored in a metadata JSON file that cargo-llvm-cov should probably be parsing instead). Until the issue is fixed in cargo-llvm-cov (or cargo-nextest adds a workaround), work around the issue by creating the special "fingerprint" directory after we extract the cargo-nextest archive ourselves. Without this patch, the coverage-related CI jobs failed with the following error as cargo-llvm-cov couldn't find the right directory for the objects: error: failed to collect object files: not found object files (searched directories: .../target/llvm-cov-target/target/debug); this may occur if show-env subcommand is used incorrectly (see docs or other warnings), or unsupported commands or configs are used Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
Since nightly-2026-08-20 rustfmt has been indent-aware (which was implemented because of an issue we opened) and so we need to now re-format a lot of comments. Unfortunately, trailing comments on lines now get the same treatment quite aggressively so a lot of those needed to be moved to no longer be trailing comments (it would be great if this bit was configurable but no such luck). Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
cyphar
force-pushed
the
gha-workflow-dispatch
branch
from
September 3, 2026 05:06
daaba41 to
9b2d54a
Compare
Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
cyphar
force-pushed
the
gha-workflow-dispatch
branch
from
September 3, 2026 05:15
9b2d54a to
34dae3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aleksa Sarai cyphar@cyphar.com