fix: stop emitting deprecated ellmer .additional_properties argument - #666
Open
krlmlr wants to merge 3 commits into
Open
fix: stop emitting deprecated ellmer .additional_properties argument#666krlmlr wants to merge 3 commits into
.additional_properties argument#666krlmlr wants to merge 3 commits into
Conversation
`ellmer` 0.5.0 deprecated the `.additional_properties` argument of `type_object()`, changing its formal default to `deprecated()`. As a result `keep_only_non_defaults()` could no longer detect `FALSE` as the default, so `construct()` emitted `.additional_properties = FALSE` for every reconstructed `TypeObject` and triggered a deprecation warning. `.additional_properties` has always defaulted to `FALSE` for `type_object()`, so only emit it when it is `TRUE`, producing idiomatic, warning-free code. Also refresh snapshots for upstream changes: - `bit64` now warns "NAs introduced by coercion to integer64 range" when coercing out-of-range strings (`test-s3-integer64.R`). - `tibble` flipped the `structure()` argument order to `row.names` before `class` (`test-s3-tbl_df.R`). Silence the `.additional_properties` deprecation warning in the tests that deliberately exercise the `additional_properties = TRUE` round-trip. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016BRYo2D5L4wpgaTFTHH2B7
krlmlr
force-pushed
the
claude/fix-cicd-failures-63v5pe
branch
from
July 22, 2026 20:58
6a1c355 to
1697466
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the R CMD check failures on the
rccandrcc devworkflows (run 29805578246), all caused by updated upstream dependencies.Before:
[ FAIL 3 | WARN 2 | SKIP 10 | PASS 236 ]After:
[ FAIL 0 | WARN 0 | SKIP 17 | PASS 232 ](extra skips are optional Suggests not installed in the local verification env)Changes
ellmer— real code fix (R/s7-elmer_TypeObject.R)ellmerdeprecated the.additional_propertiesargument oftype_object(), changing its formal default fromFALSEtodeprecated(). As a resultkeep_only_non_defaults()could no longer recogniseFALSEas the default, soconstruct()emitted.additional_properties = FALSEfor every reconstructedTypeObjectand fired a deprecation warning. Since.additional_propertieshas always defaulted toFALSEfortype_object(), we now emit it only when it isTRUE, producing idiomatic, warning-free code that round-trips again.Snapshot refreshes (upstream output changes, not regressions)
test-s3-integer64.R:bit64::as.integer64()now warnsNAs introduced by coercion to integer64 rangefor out-of-range strings; snapshot updated to capture the condition.test-s3-tbl_df.R:tibbleflipped thestructure()argument order torow.namesbeforeclass; snapshot updated (single line).Test cleanup
.additional_propertiesdeprecation warning in the twotest-s7-elmer_TypeBasic.Rblocks that deliberately exercise theadditional_properties = TRUEround-trip, viawithr::local_options(lifecycle_verbosity = "quiet").Verification
Reproduced all three failures locally (R 4.5.3, latest CRAN
bit644.8.2,tibble3.3.1,ellmer0.4.2 — the deprecation is already active in 0.4.2) and confirmed a clean run after the fix. No roxygen/exports changed, so nodocument()needed; noair.tomlpresent.🤖 Generated with Claude Code
https://claude.ai/code/session_016BRYo2D5L4wpgaTFTHH2B7
Generated by Claude Code