fix: override five dev-tree advisories with no upgrade path - #243
Merged
Conversation
Every parent is already on its latest release, so bumping a direct dependency reaches none of them. `path-equal` declares no runtime dependencies, so none of this ships to consumers — Dependabot's `runtime` scope describes the dependency's role inside its own parent, not inside the published tarball. Each override carries its advisory ID and the condition for deleting it. Removing the stale `js-yaml@>=3.0.0 <3.15.0` entry was load-bearing, not tidying: with it present the new `js-yaml` override did not take effect and 4.3.0 stayed in the tree. No js-yaml 3.x has been in this tree for some time.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the five open Dependabot advisories on
main:nanoid,js-yaml,fast-uri,postcss,brace-expansion.All five are transitive. Every parent —
vite/vitest,ajv,commitlint,depcheck,glob— is already on its latest release, so bumping a direct dependency reaches none of them. A pnpm override is the only route.Nothing here ships to consumers.
path-equaldeclares no runtime dependencies at all, so the published tarball is unaffected — Dependabot'sscope: runtimedescribes the dependency's role inside its own parent, not inside this package. That is also why this carries no changeset: the change is repo-internal.Each override carries its advisory ID and the condition for removing it, so none of them silently outlives its purpose.
One non-obvious detail
Removing the stale
js-yaml@>=3.0.0 <3.15.0entry was load-bearing rather than tidying. With it present, the newjs-yamloverride did not take effect andjs-yaml@4.3.0stayed in the tree; removing it dropped the tree to a singlejs-yaml@4.3.2. No js-yaml 3.x has been in this tree for some time, so the old entry was matching nothing while blocking the new one.Verified
pnpm installthenpnpm why <pkg> -rfor each:nanoid@3.3.16→3.3.18,js-yaml@4.3.0→ gone,fast-uri@3.1.4→3.1.6,postcss@8.5.20→ gone,brace-expansion@2.1.2→2.1.4.pnpm verifygreen on a cold turbo cache.