fix: don't blame the IP in login 429 messages - #449
Merged
Merged
Conversation
Garmin also answers 429 based on the client fingerprint, on IPs that were never used before, so 'IP rate limited' sent users chasing IP cooldowns. Reword the mobile login and all-strategies 429 messages; exception types are unchanged.
Contributor
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository: cyberjunky/python-garminconnect/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Garmin's login endpoints also return 429 based on the client fingerprint (seen on IPs that were never used before), so "IP rate limited by Garmin" sent users chasing IP cooldowns. Rewords the mobile-login and all-strategies-rate-limited messages. Exception types are unchanged.
Reported in #444. The API-session change suggested there is intentionally not included (see the discussion on the issue).
Summary by CodeRabbit