Skip to content

fix: don't blame the IP in login 429 messages - #449

Merged
cyberjunky merged 1 commit into
masterfrom
fix/429-message
Sep 29, 2026
Merged

cyberjunky merged 1 commit into
masterfrom
fix/429-message

Conversation

@cyberjunky

@cyberjunky cyberjunky commented Sep 29, 2026 •

Copy link
Copy Markdown
Owner

Garmin's login endpoints also return 429 based on the client fingerprint (seen on IPs that were never used before), so "IP rate limited by Garmin" sent users chasing IP cooldowns. Rewords the mobile-login and all-strategies-rate-limited messages. Exception types are unchanged.

Reported in #444. The API-session change suggested there is intentionally not included (see the discussion on the issue).

Summary by CodeRabbit

  • Bug Fixes
    • Clarified login error messages to explain that access may be limited based on the client or network, including client fingerprinting.

Garmin also answers 429 based on the client fingerprint, on IPs that were
never used before, so 'IP rate limited' sent users chasing IP cooldowns.
Reword the mobile login and all-strategies 429 messages; exception types
are unchanged.
@coderabbitai

coderabbitai Bot commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository: cyberjunky/python-garminconnect/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: c58cbc9b-c67b-4edb-bba8-27942ba65e75

📥 Commits

Reviewing files that changed from the base of the PR and between 337d1f9 and e77ad56.

📒 Files selected for processing (1)
  • garminconnect/client.py
 __________________________________________________________
< This abstraction leaks more than a sieve in a rainstorm. >
 ----------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cyberjunky
cyberjunky merged commit 857e93b into master Sep 29, 2026
4 of 5 checks passed
@cyberjunky
cyberjunky deleted the fix/429-message branch September 29, 2026 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant