fix: keep existing workout step payloads unchanged, add target tests - #446
Merged
Merged
Conversation
Follow-up to the targeted workouts support: - Restore the interval step and no.target displayOrder values that were changed for all interval steps, and stop sending a no.target secondaryTargetType on every step; untargeted steps upload exactly as before again. - Replace the Protocol classes and repeated field declarations with shared range/zone base classes, and drop the type: ignore in the targeted step helpers. - Document that pace limits are in m/s (slower pace is the lower limit). - Add tests for every target type, secondary targets, limit validation, the conversion helpers and the unchanged untargeted payload.
Contributor
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository: cyberjunky/python-garminconnect/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The running sample now sets a pace target on its intervals and the cycling sample a power target with a cadence secondary target, so the demo's upload options exercise the targeted workout helpers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #440.
No change for existing steps:
create_interval_step/create_distance_interval_stepwithout targets upload exactly as before Add support for targeted workouts #440 again. The interval step andno.targetdisplayOrdervalues are restored, and ano.targetsecondaryTargetTypeis no longer added to every step.Cleanup: the two
Protocolclasses and per-class field redeclarations are replaced with shared_RangeTarget/_ZoneTargetbase classes;IntensityTargetis now their union. The targeted helpers call the step functions directly, withouttype: ignore.Docs:
PaceTargetnotes that limits are in m/s, so the slower pace is the lower limit.Tests: new
tests/test_workout_targets.pycovers every target type, zone vs range targets, secondary targets, distance steps, limit validation,pace_to_mps/speed_to_mps, full workout serialization, and pins the untargeted step payload.Demo: the running sample workout now has a pace target on its intervals (
PaceTarget+pace_to_mps), and the cycling sample a 220-250 W power target with an 85-95 rpm cadence secondary target, so the demo upload options exercise the new helpers.The payload for targeted steps is unchanged from #440, which was tested live by the contributor.
Summary by CodeRabbit