Skip to content

chore: fix formatting nits from PR #432 - #435

Merged
cyberjunky merged 1 commit into
masterfrom
chore/pr432-format-nits
Sep 18, 2026
Merged

cyberjunky merged 1 commit into
masterfrom
chore/pr432-format-nits

Conversation

@cyberjunky

@cyberjunky cyberjunky commented Sep 18, 2026 •

Copy link
Copy Markdown
Owner

Summary

Two lines from #432 (menstrual-writes) didn't match ruff format's output — cosmetic only, no behavior change:

  • demo.py's workout-upload "file not found" hint was wrapped across 3 lines when it fits on one.
  • get_menstrual_reports()'s URL f-string was split across 2 lines when it fits on one.

Test plan

  • python -m pytest -q (399 passed)
  • ruff check / ruff format --check / mypy all clean

Summary by CodeRabbit

  • Style
    • Reformatted internal code for improved readability.
    • No user-visible behavior or functionality changed.

Two lines from the menstrual-writes PR didn't match ruff format's
output (an unnecessary wrap in demo.py's workout-upload error message,
and in get_menstrual_reports' URL construction) - cosmetic only, no
behavior change.
@coderabbitai

coderabbitai Bot commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 0aec2c9e-d694-481d-8ad2-ac41fa0c7cfa

📥 Commits

Reviewing files that changed from the base of the PR and between cc95938 and ca669db.

📒 Files selected for processing (2)
  • demo.py
  • garminconnect/__init__.py

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


Walkthrough

The pull request reformats one print call and one URL f-string. The printed message and generated URL remain unchanged.

Changes

Formatting cleanup

Layer / File(s) Summary
Formatting updates
demo.py, garminconnect/__init__.py
The workout file hint uses a single-line print call. The menstrual reports URL uses a single-line f-string. Both preserve existing behavior.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Suggested reviewers: tshogx

Merge Risk: ⚪ Minimal · up to ca669

The existing workout-upload message and menstrual-report URL are preserved, so this cleanup is ready to merge.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the formatting-only changes and references the related PR. It is concise and matches the main change.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cyberjunky
cyberjunky merged commit 43b0b69 into master Sep 18, 2026
8 checks passed
@cyberjunky
cyberjunky deleted the chore/pr432-format-nits branch September 18, 2026 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant