Skip to content

fix: stop demo.py's menu dispatch from needing a hardcoded key whitelist #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cyberjunky merged 1 commit into from
Sep 12, 2026
Merged

fix: stop demo.py's menu dispatch from needing a hardcoded key whitelist #430

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions demo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5173,10 +5173,14 @@ def main():
print_category_menu(current_category)
option = safe_readkey()

# Handle category menu options
# Handle category menu options. Validity is decided solely by
# membership in the current category's own options dict —
# no separate hardcoded character whitelist to keep in sync
# whenever a new option key (e.g. an uppercase letter) is
# added to menu_categories.
if option == "q":
current_category = None # Back to main menu
elif option in "0123456789abcdefghijklmnopqrstuvwxyzA":
else:
try:
category_data = menu_categories[current_category]
category_options = category_data["options"]
Expand All @@ -5190,10 +5194,6 @@ def main():
)
except Exception as e:
print(f"❌ Error processing option {option}: {e}")
else:
print(
"❌ Invalid selection. Use numbers/letters for options or 'q' to go back/quit"
)

except KeyboardInterrupt:
print("\nInterrupted by user. Press q to quit.")
Expand Down