fix: 0.1.3 follow-ups from post-0.1.2 review - #11
Merged
Merged
Conversation
…omain opt-in (0.1.3) - YYYY-MM-DD strings accepted again as UTC midnight (0.1.2 regression); naive timestamp strings still rejected - safe_markdown_url: urlsplit validation (scheme+netloc), percent-encode <>() and spaces — closes https://...><script> breakout - custom domain now requires allow_custom_domain=True (key forwarding guard) - briefing example catches CurrentsAPIError, prints HTTP status cleanly - 15 new tests (66 total incl. 13 briefing-security regressions)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four follow-ups from independent post-0.1.2 review (all confirmed before fixing):
search(start_date="2024-01-01")form. Restored: date-only strings parse viadate.fromisoformat→ UTC midnight. Naive timestamp strings remain rejected.safe_markdown_urlallowedhttps://...><script>...through. Now urlsplit-validates (scheme + netloc) and percent-encodes<>()and spaces. Repro'd with a real renderer pre-fix.CurrentsAPI(key, domain=other)now requires explicitallow_custom_domain=True.CurrentsAPIErrorand printserror: Currents API request failed (HTTP <status>): <message>.66 tests pass (15 new: date-only, naive-ts-string, domain opt-in, 13 briefing-security). twine check PASSED.