fix(client): hardening round from external audit (0.1.2) - #10
Merged
Merged
Conversation
…tion (0.1.2) - restore python-dateutil>=2.8.0 compat (drop ParserError reference) - non-JSON/non-object error responses raise CurrentsAPIError with HTTP status - status property prefers real HTTP status over payload value - reject falsey/whitespace keywords; reject naive datetimes; date -> UTC midnight - sanitize briefing example markdown/URLs (blocks javascript: injection) - 7 new regression tests (51 total)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the SHIP-WITH-FIXES findings from an independent external audit of the published 0.1.1 (all findings reproduced against source before fixing).
Fixes
_parse_datereferencedparser.ParserError(added in dateutil 2.8.1) while setup.py declares>=2.8.0; on 2.8.0 the handler itself raisedAttributeError. Now catches(ValueError, OverflowError)only.JSONDecodeError; non-object payloads ([]) raisedAttributeErrorinside the exception. Both now raiseCurrentsAPIError..statusprefers the real HTTP status code; payloadstatusis fallback only.keywords=0/" "rejected instead of silently omitted; all params useis not Noneguards.Zsuffix).dateobjects explicitly formatted as UTC midnight.examples/_example_utils.py; verified with a real markdown renderer that the raw form produced a live<a href="javascript:...">link and the escaped form is inert.Validation