Skip to content

chore(deps): drop the jakarta.annotation-api pin the imported BOM already sets - #262

Merged
cuioss-oliver merged 1 commit into
mainfrom
chore/drop-duplicated-jakarta-annotation-pin
Sep 8, 2026
Merged

cuioss-oliver merged 1 commit into
mainfrom
chore/drop-duplicated-jakarta-annotation-pin

Conversation

@cuioss-oliver

Copy link
Copy Markdown
Collaborator

Part of an org-wide dependency-version centralization pass across the 18 cuioss repos.

What

This pom declares jakarta.annotation:jakarta.annotation-api at a literal 3.0.0 in its own
dependencyManagement, and then — three lines further down, in the same block — imports
de.cuioss:java-ee-10-bom, which manages that exact coordinate at that exact value via
version.jakarta.annotation-api.

A directly declared entry outranks an imported BOM regardless of order, so the local pin was
silently shadowing the import while agreeing with it. That is the worst of both worlds: it reads
like a deliberate override, and it would keep reading like one on the day the BOM's value moves —
at which point this repo would quietly stay behind.

Verification

dependency:list -DincludeScope=test   byte-identical before and after
clean install                          BUILD SUCCESS

The baseline and the post-change listing both contain
jakarta.annotation:jakarta.annotation-api:jar:3.0.0:provided — same coordinate, same version,
same scope, now sourced from the import instead of the local literal.

🤖 Generated with Claude Code

https://claude.ai/code/session_01FS7nXoXh43D2EzEAkn3APT

…eady sets

This pom declares jakarta.annotation-api at a literal 3.0.0 in its own
dependencyManagement, and then - three lines further down, in the same block -
imports de.cuioss:java-ee-10-bom, which manages that exact coordinate at that
exact version via version.jakarta.annotation-api.

A directly declared entry outranks an imported BOM regardless of order, so the
local pin was silently shadowing the import while agreeing with it. That is the
worst of both: it looks like a deliberate override, and it would keep looking
like one the day the BOM's value moves.

Verified: dependency:list -DincludeScope=test is byte-identical before and
after, with jakarta.annotation:jakarta.annotation-api:jar:3.0.0:provided still
present, now sourced from the import. clean install BUILD SUCCESS.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FS7nXoXh43D2EzEAkn3APT
@cuioss-oliver cuioss-oliver added the skip-bot-review Skip automated bot code review (Gemini/CodeRabbit/Sourcery) label Sep 8, 2026

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @cuioss-oliver, you've used your own review budget of 250,000 diff characters for the last 7 days.

You can request another review in 50 minutes by commenting @sourcery-ai review. Upgrade to get a review now.

@coderabbitai

coderabbitai Bot commented Sep 8, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • skip-bot-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: cuioss/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 7032fc54-ece5-45a9-8a2a-ba62382a4892

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cuioss-oliver
cuioss-oliver added this pull request to the merge queue Sep 8, 2026
Merged via the queue into main with commit 60255ed Sep 8, 2026
23 checks passed
@cuioss-oliver
cuioss-oliver deleted the chore/drop-duplicated-jakarta-annotation-pin branch September 8, 2026 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-bot-review Skip automated bot code review (Gemini/CodeRabbit/Sourcery)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant