Repository navigation
chore(deps): drop the jakarta.annotation-api pin the imported BOM already sets - #262
Conversation
…eady sets This pom declares jakarta.annotation-api at a literal 3.0.0 in its own dependencyManagement, and then - three lines further down, in the same block - imports de.cuioss:java-ee-10-bom, which manages that exact coordinate at that exact version via version.jakarta.annotation-api. A directly declared entry outranks an imported BOM regardless of order, so the local pin was silently shadowing the import while agreeing with it. That is the worst of both: it looks like a deliberate override, and it would keep looking like one the day the BOM's value moves. Verified: dependency:list -DincludeScope=test is byte-identical before and after, with jakarta.annotation:jakarta.annotation-api:jar:3.0.0:provided still present, now sourced from the import. clean install BUILD SUCCESS. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FS7nXoXh43D2EzEAkn3APT
There was a problem hiding this comment.
Sorry @cuioss-oliver, you've used your own review budget of 250,000 diff characters for the last 7 days.
You can request another review in 50 minutes by commenting @sourcery-ai review. Upgrade to get a review now.
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: cuioss/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Part of an org-wide dependency-version centralization pass across the 18 cuioss repos.
What
This pom declares
jakarta.annotation:jakarta.annotation-apiat a literal3.0.0in its owndependencyManagement, and then — three lines further down, in the same block — importsde.cuioss:java-ee-10-bom, which manages that exact coordinate at that exact value viaversion.jakarta.annotation-api.A directly declared entry outranks an imported BOM regardless of order, so the local pin was
silently shadowing the import while agreeing with it. That is the worst of both worlds: it reads
like a deliberate override, and it would keep reading like one on the day the BOM's value moves —
at which point this repo would quietly stay behind.
Verification
The baseline and the post-change listing both contain
jakarta.annotation:jakarta.annotation-api:jar:3.0.0:provided— same coordinate, same version,same scope, now sourced from the import instead of the local literal.
🤖 Generated with Claude Code
https://claude.ai/code/session_01FS7nXoXh43D2EzEAkn3APT