Repository navigation
Venue fix, recovery flags and real-robot postmortem - #4
Merged
Merged
Conversation
…rs, bin paper outside / cardboard inside)
…r blobs before split_blobs The venue G1 picked an orange bin: one large orange bin blob passes the height window (keep mask caps pixels at 9 cm, rim tops sit inside it) and split_blobs then slices it into up to 3 cube-sized parts that each pass _reject. The guard rejects the whole blob first when its area exceeds 4x the expected single-object area, its top is > 7.5 cm above the counter, or its 3D footprint extent is > 13 cm. ON in finals_r25_gen, OFF in profile_auto.sim_overrides and stock.
…t (no depth, no GPU)
…mponent) and gate_below_bins row_median_px knob
…_r25_gen, instruction-first sort_fixed mapping - finals_r25_gen: perception.bin_image_guard true, gate_below_bins_params.first_run_top_frac 0.55 (new registered knob, default 0.45); both stay on under profile_auto.sim_overrides (perception-only) - bin_image_guard also keeps the nominal in_bin reject active while the image gate_below_bins is on; the colour-gate hedged bin rule is deliberately not re-enabled (it rejected real cubes in the venue replay) - policy_server no longer injects the venue map for sort_fixed when policy.fixed_instruction_first is on, so the instruction's full mapping (venue sentence: red left, yellow center, blue right) is used, else fixed_mapping - venue replay harness pins the pre-fix values per named config and gains a "shipping" config - tests: test_bin_gate_defence, mapping tests, flag registries, CI module list
…g_object_recovery (lift margin, bounded release_confirm recovery) Both flags default off, on in finals_r25_gen. Stub unit tests in test_wrong_object_recovery.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the venue fixes (bin_image_guard, first_run_top_frac 0.55, instruction-first mapping), the venue twin DR and replay tool, bin.vote logging and tape_body_reject, and a README postmortem.
grasp.wrong_object_recovery is implemented but OFF in finals_r25_gen: no genuine-grasp lift finger_sum was ever measured against its 0.09 threshold.
Validation: offline venue replay (on-bin candidates 20 -> 2, 55/55 objects still found); unit modules from tools/ci_unit_modules.txt pass (467 tests). The Isaac A/B was inconclusive (all arms 0/15, forced real profile does not sort in sim).