Tran/set up weekly challenges by tnt07-t · Pull Request #225 · cuappdev/uplift-backend

tnt07-t · 2025-11-25T03:57:41Z

Title

Added weekly_challenge table and query by date

Overview

Added table weekly_challenge.py in data base and added query get_weekly_challenge_by_date and added but commented out CreateWeeklyChallenge

Changes Made

I populated weekly_challenge table with name, message, start_date, and end_date, added serialize, and added query get_weekly_challenge_by_date

Test Coverage

Tested locally

…in schema.py

nfq2

i left a couple of comments for small fixes. also, since ur changing the database and adding a new table you need to add a migration (tells our database what changes it needs to make). u can prob just ask chatgpt how to do this since i'm not 100% what the commands are but try:

generate migration file: alembic revision --autogenerate -m "add <table>"
syncs ur DB and apply changes to ur db: alembic upgrade head
push the new changes it added to ur branch as well (migrations/versions)

you might also wanna do some testing by creating new challenges and seeing if you can get them using ur endpoint

cejiogu · 2026-03-03T07:49:57Z

Note: Because we are using a GraphQL API, we don't need a serialize function, as the serialization is implemented on a field-level in the schema.py file

houndci-bot · 2026-09-23T22:27:47Z

+
+
+
+def downgrade():


too many blank lines (4)

houndci-bot · 2026-09-23T22:27:47Z

+                    sa.PrimaryKeyConstraint('id')
+                    )
+
+


blank line contains whitespace

houndci-bot · 2026-09-23T22:27:47Z

+                    sa.Column('weekly_challenge_id', sa.Integer(), nullable=False),
+                    sa.Column('completed_at', sa.DateTime(timezone=True), nullable=True),
+                    sa.Column('points', sa.Integer(), nullable=False),
+                    sa.Column('status', sa.Enum('NOT_STARTED', 'IN_PROGRESS', 'COMPLETED', name='userweeklychallengestatusenum'), nullable=False, server_default='NOT_STARTED'),


line too long (176 > 120 characters)

houndci-bot · 2026-09-23T22:27:47Z

+
+
+# revision identifiers, used by Alembic.
+revision = '1063ea54c7b9'


Black would make changes.

houndci-bot · 2026-09-23T22:27:47Z

+                    sa.Column('rule_config', postgresql.JSONB(), nullable=True),
+                    sa.Column('is_active', sa.Boolean(), nullable=False, server_default=sa.true()),
+                    sa.Column('created_at', sa.DateTime(timezone=True), nullable=False, server_default=sa.text('CURRENT_TIMESTAMP')),
+                    sa.Column('updated_at', sa.DateTime(timezone=True), nullable=False, server_default=sa.text('CURRENT_TIMESTAMP'), onupdate=sa.text('CURRENT_TIMESTAMP')),


line too long (172 > 120 characters)

houndci-bot · 2026-09-23T22:27:47Z

+    status = Column(Enum(UserWeeklyChallengeStatus), nullable=False, default=UserWeeklyChallengeStatus.NOT_STARTED)
+    is_completed = Column(Boolean, nullable=False, default=False)
+
+    __table_args__ = (UniqueConstraint('user_id', 'weekly_challenge_id', name='unique_user_weekly_challenge'),)


no newline at end of file

houndci-bot · 2026-09-23T22:27:47Z

+    """
+    __tablename__ = "user_weekly_challenges"
+
+    id = Column(Integer, primary_key = True, autoincrement = True)


unexpected spaces around keyword / parameter equals

houndci-bot · 2026-09-23T22:27:47Z

@@ -0,0 +1,27 @@
+from datetime import datetime
+from sqlalchemy import Column, Integer, String, Date, DateTime, Enum, Boolean, ForeignKey, UniqueConstraint


'sqlalchemy.Date' imported but unused
'sqlalchemy.String' imported but unused
Black would make changes.

houndci-bot · 2026-09-23T22:27:47Z

@@ -0,0 +1,27 @@
+from datetime import datetime


'datetime.datetime' imported but unused

houndci-bot · 2026-09-23T22:27:47Z

+    is_active = Column(Boolean, nullable = False, default = True)
+
+    created_at = Column(DateTime(timezone=True), nullable = False, default=lambda: datetime.now(timezone.utc), server_default=text("CURRENT_TIMESTAMP"))
+    updated_at = Column(DateTime(timezone=True), nullable = False, default=lambda: datetime.now(timezone.utc), server_default=text("CURRENT_TIMESTAMP"), onupdate=lambda: datetime.now(timezone.utc))


no newline at end of file
unexpected spaces around keyword / parameter equals

coderabbitai · 2026-09-23T22:27:47Z

Important

🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: cde9df77-f1ab-4bd3-aba9-5ef48d8bcb99

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

houndci-bot · 2026-09-23T22:31:51Z

+            "start_date": self.start_date.isoformat(),
+            "end_date": self.end_date.isoformat()
+        }
+


blank line at end of file
blank line contains whitespace

houndci-bot · 2026-09-23T22:31:51Z

+    end_date = Column (Date, nullable = False)
+
+
+    def serialize(self):


too many blank lines (2)

houndci-bot · 2026-09-23T22:31:51Z

+    name = Column(String, nullable = False)
+    message = Column(String, nullable = False)
+    start_date = Column(Date, nullable = False)
+    end_date = Column (Date, nullable = False)


unexpected spaces around keyword / parameter equals
whitespace before '('

houndci-bot · 2026-09-23T22:31:52Z

+    id = Column(Integer, primary_key = True, autoincrement = True)
+    name = Column(String, nullable = False)
+    message = Column(String, nullable = False)
+    start_date = Column(Date, nullable = False)


unexpected spaces around keyword / parameter equals

houndci-bot · 2026-09-23T22:31:52Z

+
+    id = Column(Integer, primary_key = True, autoincrement = True)
+    name = Column(String, nullable = False)
+    message = Column(String, nullable = False)


unexpected spaces around keyword / parameter equals

houndci-bot · 2026-09-23T22:31:52Z

+            name = name,
+            message = message,
+            start_date = start_date,
+            end_date = end_date,


unexpected spaces around keyword / parameter equals

houndci-bot · 2026-09-23T22:31:52Z

+        new_challenge = WeeklyChallengeModel(
+            name = name,
+            message = message,
+            start_date = start_date,


unexpected spaces around keyword / parameter equals

houndci-bot · 2026-09-23T22:31:52Z

+        #Create new weekly challenge
+        new_challenge = WeeklyChallengeModel(
+            name = name,
+            message = message,


unexpected spaces around keyword / parameter equals

houndci-bot · 2026-09-23T22:31:52Z

+
+        #Create new weekly challenge
+        new_challenge = WeeklyChallengeModel(
+            name = name,


unexpected spaces around keyword / parameter equals

houndci-bot · 2026-09-23T22:31:52Z

+        if end_date <= start_date:
+            raise GraphQLError("End date must be after start date")
+
+        #Create new weekly challenge


block comment should start with '# '

tnt07-t added 2 commits November 24, 2025 16:54

added weekly_challenge table and query get_ weekly_challenge_by_date …

1a9ddde

…in schema.py

added weekly challenge model

afe9a57

tnt07-t requested review from Aayush-Agnihotri, akmatchev and nfq2 and removed request for Aayush-Agnihotri November 25, 2025 03:58

nfq2 requested changes Nov 25, 2025

View reviewed changes

Comment thread requirements.txt

Comment thread src/schema.py Outdated

added CreateWeeklyChallenge

860553a

houndci-bot reviewed Sep 23, 2026

View reviewed changes

cejiogu force-pushed the tran/set-up-weekly-challenges branch from f0a42a5 to 860553a Compare September 23, 2026 22:31

houndci-bot reviewed Sep 23, 2026

View reviewed changes



		# revision identifiers, used by Alembic.
		revision = '1063ea54c7b9'

		@@ -0,0 +1,27 @@
		from datetime import datetime
		from sqlalchemy import Column, Integer, String, Date, DateTime, Enum, Boolean, ForeignKey, UniqueConstraint

		end_date = Column (Date, nullable = False)


		def serialize(self):

Conversation

tnt07-t commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Title

Overview

Changes Made

Test Coverage

Uh oh!

nfq2 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cejiogu commented Mar 3, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot commented Sep 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tnt07-t commented Nov 25, 2025 •

edited

Loading

coderabbitai Bot commented Sep 23, 2026 •

edited

Loading