[Profile] Add guest profile sign-in flow - #116
conniecliu wants to merge 1 commit into
Conversation
This implements the skip sign-in flow for when a user skips the sign-in prompt. Changes include: - New guest profile screen that appears when a user is not logged in. - Replaced main logo png with xml for visual clarity. - Modified buttons and navigation for new flow and UI.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (7)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe PR adds a guest profile screen with Google sign-in, updates sign-in button modifiers, adds supporting icons, and changes root navigation to select guest content and clear onboarding routes when navigating Home. ChangesGuest profile navigation
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant RootNavigationViewModel
participant MainNavigationWrapper
participant GuestProfileScreen
participant LoginViewModel
RootNavigationViewModel->>MainNavigationWrapper: emit session navigation event
MainNavigationWrapper->>GuestProfileScreen: render guest profile
GuestProfileScreen->>LoginViewModel: invoke Google sign-in
Merge Risk: ⚪ Minimal · up to No concrete merge-blocking risk remains in the guest profile and navigation changes. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 10.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 10 functions across 5 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Overview
This implements the skip sign-in flow for when a user skips the sign-in prompt. Changes include:
Details on the flow and UI can be found in this Figma.
Changes Made
GuestProfileScreenthat appears only if the user skipped the sign-in prompt during early onboarding.GuestProfileScreenMainNavigationWrapperandRootNavigationViewModelto prevent the user from backing back into the onboarding flow after onboarding is completed + direct them to login if they haven't already + be directed to Home.Test Coverage
Screenrecording
Summary by CodeRabbit