Change view type to a radio so that only one type is selectable (D888) - #645
Open
droberts-ctrlo wants to merge 1 commit into
Open
Change view type to a radio so that only one type is selectable (D888)#645droberts-ctrlo wants to merge 1 commit into
droberts-ctrlo wants to merge 1 commit into
Conversation
droberts-ctrlo
changed the title
pwlodarski-ctrlo
left a comment
pwlodarski-ctrlo
left a comment
There was a problem hiding this comment.
PR reviewed - appears fine, just one minor clarification comment.
| const value = this.el.data("radio-value"); | ||
|
|
||
| if (!target || !value) { | ||
| console.error("RadioRevealComponent: Missing data-radio-target or data-radio-value attribute."); |
There was a problem hiding this comment.
Is this picked up by our /scripterror frontend error catching endpoint?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.