Conversation
Still requires: * Front-end configuration of user's MFA and site-wide policy * Ability for an admin to reset a user's MFA (use reset_mfa())
pwlodarski-ctrlo
left a comment
pwlodarski-ctrlo
left a comment
There was a problem hiding this comment.
PR reviewed - couple comments added.
| { | ||
| my $mfa_cookie = cookie 'MFATOKEN'; | ||
| # MFA needed before access? | ||
| redirect '/mfa' if request->uri !~ m!^/(mfa|logout)$! |
There was a problem hiding this comment.
Should the / delimiter have an \ escape before it?
| warning "The authentication token has already been used in the last 5 minutes, possibly an attacker?" | ||
| if $user->mfa_token_previous && $user->mfa_token_previous eq $token | ||
| && $user->mfa_token_previous_used->clone->add(minutes => 5) > DateTime->now; | ||
| # Allow a token to be reused. Generate a random token and |
There was a problem hiding this comment.
I don't believe we wish to make the tokens reusable.
|
|
||
| sub _refresh_recent_mfa_cookie | ||
| { my $key = shift; | ||
| cookie MFATOKEN => $key, expires => '7d', secure => 1, http_only => 1; |
There was a problem hiding this comment.
HTTP isn't a secure means, do we need the http_only flag?
Because the MFA cookie is now renewed every page render, it is possible that a user only using the system weekly will never need to authenticate with MFA. Reduce the time to 2 days to ensure weekly MFA if not logging in at the weekend.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still requires: