feat(solana-orderbook) PR02: GET order endpoint with fill state - #4764
feat(solana-orderbook) PR02: GET order endpoint with fill state#4764squadgazzz wants to merge 9 commits into
Conversation
|
Claude finished @squadgazzz's task in 3m 37s —— View job PR Review: GET order endpoint with fill stateReviewed the endpoint, DB read, and status derivation. This is a clean, tightly-scoped PR — the status precedence (fulfilled → cancelled → expired → open) matches the EVM orderbook's derivation in One minor inline comment posted:
Nothing blocking. Nice work.
|
|
Reminder: Please consider backward compatibility when modifying the API specification.
Caused by: |
There was a problem hiding this comment.
did you run this through one of those openapi spec validators?
the existing one would be quite a PITA to fix but we could start with this one from the get go to get higher quality specs
There was a problem hiding this comment.
Yes, swagger-cli validate plus spectral lint. Also, added to CI. Later, I'll probably add utopia to finally generate the file.
Description
GET /api/v1/orders/{uid}serves one order with its fill state, mostly for the explorer. Unknown uid answers 404, a malformed one 400.The path sits under
/api/v1so the route shapes match the EVM orderbook.Changes
GET /api/v1/orders/{uid}: a read joiningsolana.orderswithsolana.order_pda, plus the wire DTO with the status derivationHow to test
New unit tests and a Postgres test for the query.