feat: preserve glob imports in generated migrations - #662
Open
oxura wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The symbol resolver cannot enumerate names introduced by a glob import, so model field types reached generated migrations without either a fully resolved path or the import that made the name visible. It also emitted a warning even though the generator can preserve the original scope another way.
The resolver now extracts top-level glob branches from ordinary and grouped
usetrees. It rewritesselfandsuperprefixes to stable crate-relative paths, preserves attributes such ascfg, and leaves explicit imports on the existing symbol-resolution path. Models carry those imports into generated migrations; imports from multiple changed models are deduplicated before emission.Verification:
superglob importscargo +1.94.0 fmt --all -- --checkunknown-lintsallowed for the upstream toolchain compatibility issue)Closes #69.