Skip to content

fix(integration): drop the removed Conductor integration from connect - #143

Open
polylane[bot] wants to merge 1 commit into
mainfrom
polylane/autofix/382yfn8vkz0m
Open

polylane[bot] wants to merge 1 commit into
mainfrom
polylane/autofix/382yfn8vkz0m

Conversation

@polylane

@polylane polylane Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

The CI typecheck on main failed because the CLI still offered the Conductor integration, which the API removed on 2026-11-05. The build regenerates the client type from the live spec, so the compiler rejected the CLI source that named Conductor. After this change the CLI no longer offers Conductor and the build compiles again. The API removed Conductor (nominal#6150, "the Conductor service is shutting down"), so the generated IntegrationType lost conductor. src/commands/integration/connect.ts still declared it, and tsc failed. Removing it makes npm run typecheck pass and no longer offers an integration the API rejects.

flowchart LR
  A["nominal #6150 removes the Conductor integration"] --> B["Prod OpenAPI spec: IntegrationType loses conductor"]
  B --> C["CLI CI codegen regenerates src/generated/types.ts"]
  C --> D["tsc: connect.ts still names conductor"]
  D --> E["Typecheck fails, CI red on cli@main"]
  F["This change: drop Conductor from connect.ts"] -.-> D
Loading

Fix walkthrough

Watch the fix walkthrough

Watch the fix explained (1:14). Recorded for commit 67bf5581d3a6d3de92cb4ed9b048e178a8da7fbf.

Production impact

CLI source-only removal; no deployed resource behavior changes

I changed only src/commands/integration/connect.ts and its test in coreplanelabs/cli. That repository has no deploy edges in the infrastructure graph (getNodeEdges returned 0), so the change reaches no deployed resource; the CLI is a published package, not a running service. The edit removes a reference to an integration the API already removed, so it cannot degrade production.

Observability

  • CI's checks job runs npm run codegen then npm run typecheck on every push; the typecheck step is the signal that this change fixes.
  • npm test covers the connect type-options surface (test/integration-connect-category.test.ts).

Polylane assessed this pull request at 67bf558.

Causal chain
  • Signal (alert): CI failing: CI on coreplanelabs/cli@main
  • Surfacing site: coreplanelabs/cli at coreplanelabs/cli:src/commands/integration/connect.ts#isCodeAgentType
  • Mechanism: The CLI regenerates its client from the live OpenAPI spec; that spec no longer defines an integration type named "conductor", so the generated IntegrationType union lacks it and the CLI's ConnectableType union and type predicate are not assignable to it. tsc fails at the type predicate and the connect-body assignment.
  • Producer: coreplanelabs/cli, at src/commands/integration/connect.ts
  • Trigger: nominal#6150 deployed removal of the Conductor integration to the production API on 2026-11-05; the next CLI push regenerated the client without conductor.
  • What happens to the failed unit today: package.json pretypecheck runs codegen before tsc --noEmit, so CI's typecheck always compiles against the current API spec.
  • Last observed: 2026-11-10T17:37:36Z
  • Blast radius: 0 other resource(s), 0 other tenant(s); data at risk: none named
  • Producer evidence:
    • nominal PR #6150 "feat(integrations): remove the Conductor integration" merged 2026-11-05T01:36:40Z (CHANGELOG 3.171.0); the API deliberately removed Conductor.
    • CI log for run 42866675551: connect.ts(422,64) TS2677 and connect.ts(1497,14) TS2322, both because "conductor" is not assignable to IntegrationType.
    • npm run codegen against https://api.polylane.com/v1/doc wrote types.ts whose IntegrationType lists every type except conductor.
    • After removing the Conductor references, npx tsc --noEmit exits 0 and npm test reports 617/617 pass.
2 files changed (+5/-15)
  • src/commands/integration/connect.ts: modified, +1/-11
  • test/integration-connect-category.test.ts: modified, +4/-4

View autofix


Generated by Polylane. You can ask follow-ups by mentioning @polylane in a comment. If you close this pull request without merging, add a comment that says why. Polylane reads it to make its next fixes better.

Co-authored-by: polylane[bot] <277585245+polylane[bot]@users.noreply.github.com>
@polylane polylane Bot added polylane severity:medium Polylane autofix severity: medium labels Nov 10, 2026
@polylane
polylane Bot requested review from boristane and nwm-54 November 10, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

polylane severity:medium Polylane autofix severity: medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant