Repository navigation
fix(pantry): don't wrap "optional" in a second pair of parentheses - #627
Merged
Merged
Conversation
Every locale already writes pantry-optional with its parentheses, so the add-item dialog read "Quantity ((optional))" in every language. Leave the punctuation to the translations, and check that no template wraps such a message again. Closes cooklang#626 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #626.
Every locale already writes
pantry-optionalwith its parentheses ((optional),(optionnel),(opcional)…), andtemplates/pantry.htmlwrapped it in a second pair on the four optional fields of the Add item dialog, so they read "Quantity ((optional))" in every language. Both came in with d4c5007.templates/pantry.html: drop the template's parentheses; the punctuation stays with the translations.tests/locales_test.rs:no_template_wraps_a_parenthesised_message_in_parentheseslists the English messages written in parentheses and fails if a template wraps one in({{ tr.t("…") }}). It fails onmain(pantry.html: pantry-optional) and passes here.cargo fmt --check,cargo clippy --all-targetsandcargo testpass.🤖 Generated with Claude Code