fix(website): keep global search results consistent with selected column scopes - #99
Open
Bircck wants to merge 1 commit into
Open
fix(website): keep global search results consistent with selected column scopes#99Bircck wants to merge 1 commit into
Bircck wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Global data-type searches could find a table but hide its matching columns, while empty results could leave search unfinished. Use shared matching rules for the worker and displayed rows, respect the selected column scopes, and support displayed choice and date labels.
Validation: 12 scoped matching assertions and six worker scenarios; synthetic before/after browser checks for visible type matches and empty results; pinned website lint and full production build/postbuild passed.