Repository navigation
Conversation
usiegl00
force-pushed
the
pidfd-returns-ENOENT
branch
from
October 21, 2026 06:58
836d0c0 to
4256e76
Compare
Collaborator
|
Thank you! Just one nit in the comment, otherwise LGTM |
In commit 8cf4b738f6d8, "pidfd: improve uapi when task isn't found" pidfd_open() now returns ENOENT instead of EINVAL when the pid exists but is not the leader of a thread-group. This occurs when the pid space wraps under significant pid churn. The simple fix is to treat ENOENT the same as EINVAL when handling the errno of pidfd_open. This prevents stopped containers from accumulating when the pid space wraps. Signed-off-by: usiegl00 <50933431+usiegl00@users.noreply.github.com>
usiegl00
force-pushed
the
pidfd-returns-ENOENT
branch
from
October 21, 2026 08:41
4256e76 to
75fa6f3
Compare
Author
|
@kolyshkin updated the comment to reflect the right version |
Member
|
please use your real name and email for the commit author and DCO |
giuseppe
added a commit
to giuseppe/crun
that referenced
this pull request
Oct 21, 2026
In commit 8cf4b738f6d8, "pidfd: improve uapi when task isn't found" pidfd_open() now returns ENOENT instead of EINVAL when the pid exists but is not the leader of a thread-group. Carried over from containers#2394 Signed-off-by: Giuseppe Scrivano <giuseppe@scrivano.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In commit 8cf4b738f6d8, "pidfd: improve uapi when task
isn't found" pidfd_open() now returns ENOENT instead of EINVAL when the
pid exists but is not the leader of a thread-group.
This occurs when the pid space wraps under significant pid churn.
The simple fix is to treat ENOENT the same as EINVAL when handling the
errno of pidfd_open. This prevents stopped containers from accumulating
when the pid space wraps.
ENOENT is returned in linux 6.15-rc2 and onwards.