Skip to content

feat(errors): register SIGN_UP_REQUIRES_INVITE and INVITE_PHONE_NOT_FOUND - #1824

Merged
pyramation merged 1 commit into
mainfrom
feat/invite-only-signup-errors
Sep 10, 2026
Merged

feat(errors): register SIGN_UP_REQUIRES_INVITE and INVITE_PHONE_NOT_FOUND#1824
pyramation merged 1 commit into
mainfrom
feat/invite-only-signup-errors

Conversation

@pyramation

Copy link
Copy Markdown
Contributor

Summary

Registers the two public error codes introduced by invite-only sign-up in constructive-io/constructive-db#3730 so transports classify them as public (403/404) instead of failing safe to an unregistered 500.

  • SIGN_UP_REQUIRES_INVITE (403) — raised by every sign_up* function when app_settings_auth.sign_up_requires_invite is on and no invite_token was supplied.
  • INVITE_PHONE_NOT_FOUND (404) — raised by claim_app_invite when a phone-addressed invite is claimed by a user who doesn't own that phone (mirror of INVITE_EMAIL_NOT_FOUND).

scripts/db-error-inventory.json and src/generated/registry.generated.ts were regenerated via audit-db-errors.py + generate-registry.py against that branch; curated copy for both codes was added to registry.ts.

Link to Devin session: https://app.devin.ai/sessions/b594a9d9c24e40ec9968fef407df5af3
Open in Devin Desktop: https://app.devin.ai/desktop/session/b594a9d9c24e40ec9968fef407df5af3?variant=devin
Requested by: @pyramation

…OUND

Re-ran the constructive-db audit (constructive-db#3730, invite-only sign-up)
and regenerated the registry; curated public copy for both codes.
@devin-ai-integration

Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@tenki-reviewer

tenki-reviewer Bot commented Sep 10, 2026

Copy link
Copy Markdown

Review complete. No issues found — approved ✅.


This PR updates the Constructive errors package. It adds two new error definitions, SIGN_UP_REQUIRES_INVITE and INVITE_PHONE_NOT_FOUND, to the DB error inventory and registry, and adds a "class": "public" field to several existing error entries while refreshing occurrence counts.

Files Change
packages/errors/scripts/db-error-inventory.json Adds the two new invite error entries, marks several existing errors as public, and refreshes occurrence counts.
packages/errors/src/registry.ts Registers the two new error codes consistently with the inventory.

The inventory and registry stay in sync, the JSON is valid, and no defects were found across correctness, API-data, and holistic review.

Reviewed commit: ea074ed

@pyramation
pyramation merged commit 71c7530 into main Sep 10, 2026
21 checks passed
@pyramation
pyramation deleted the feat/invite-only-signup-errors branch September 10, 2026 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant