feat(errors): register SIGN_UP_REQUIRES_INVITE and INVITE_PHONE_NOT_FOUND - #1824
Merged
Conversation
…OUND Re-ran the constructive-db audit (constructive-db#3730, invite-only sign-up) and regenerated the registry; curated public copy for both codes.
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Review complete. No issues found — approved ✅. This PR updates the Constructive errors package. It adds two new error definitions, SIGN_UP_REQUIRES_INVITE and INVITE_PHONE_NOT_FOUND, to the DB error inventory and registry, and adds a "class": "public" field to several existing error entries while refreshing occurrence counts.
The inventory and registry stay in sync, the JSON is valid, and no defects were found across correctness, API-data, and holistic review. Reviewed commit: ea074ed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Registers the two public error codes introduced by invite-only sign-up in constructive-io/constructive-db#3730 so transports classify them as
public(403/404) instead of failing safe to an unregistered500.SIGN_UP_REQUIRES_INVITE(403) — raised by everysign_up*function whenapp_settings_auth.sign_up_requires_inviteis on and noinvite_tokenwas supplied.INVITE_PHONE_NOT_FOUND(404) — raised byclaim_app_invitewhen a phone-addressed invite is claimed by a user who doesn't own that phone (mirror ofINVITE_EMAIL_NOT_FOUND).scripts/db-error-inventory.jsonandsrc/generated/registry.generated.tswere regenerated viaaudit-db-errors.py+generate-registry.pyagainst that branch; curated copy for both codes was added toregistry.ts.Link to Devin session: https://app.devin.ai/sessions/b594a9d9c24e40ec9968fef407df5af3
Open in Devin Desktop: https://app.devin.ai/desktop/session/b594a9d9c24e40ec9968fef407df5af3?variant=devin
Requested by: @pyramation